-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add compat data for ServiceWorkerContainer #1011
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost! The usual notes -? flags for Edge has to be fixed, but, besides of this, it is fine!
api/ServiceWorkerContainer.json
Outdated
}, | ||
"edge": { | ||
"version_added": "17", | ||
"notes": "Behind a flag since EdgeHTML 16." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"flags"
api/ServiceWorkerContainer.json
Outdated
}, | ||
"edge": { | ||
"version_added": "17", | ||
"notes": "Behind a flag since EdgeHTML 16." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"flags"
api/ServiceWorkerContainer.json
Outdated
}, | ||
"edge": { | ||
"version_added": "17", | ||
"notes": "Behind a flag since EdgeHTML 16." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"flags"
api/ServiceWorkerContainer.json
Outdated
}, | ||
"edge": { | ||
"version_added": "17", | ||
"notes": "Behind a flag since EdgeHTML 16." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"flags"
api/ServiceWorkerContainer.json
Outdated
}, | ||
"edge": { | ||
"version_added": "17", | ||
"notes": "Behind a flag since EdgeHTML 16." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"flags"
api/ServiceWorkerContainer.json
Outdated
}, | ||
"edge": { | ||
"version_added": "17", | ||
"notes": "Behind a flag since EdgeHTML 16." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"flags"
api/ServiceWorkerContainer.json
Outdated
}, | ||
"edge": { | ||
"version_added": "17", | ||
"notes": "Behind a flag since EdgeHTML 16." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"flags"
api/ServiceWorkerContainer.json
Outdated
}, | ||
"edge": { | ||
"version_added": "17", | ||
"notes": "Behind a flag since EdgeHTML 16." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"flags"
api/ServiceWorkerContainer.json
Outdated
}, | ||
"edge": { | ||
"version_added": "17", | ||
"notes": "Behind a flag since EdgeHTML 16." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"flags"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah! LGTM, r+
* Add compat data for ServiceWorkerContainer * Edit Edge 16 behind flag, 17 by default, add Samsung Internet
https://developer.mozilla.org/en-US/docs/Web/API/ServiceWorkerContainer
as #1002 notes on ESR might need editing.