Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Chrome compatibility data of ServiceWorkerContainer.getRegistrations #3251

Merged
merged 1 commit into from
Jan 4, 2019

Conversation

kenrick95
Copy link
Contributor

The old table at MDN page states that it is only supported on Chrome 45 onwards

This error has been there since initial PR #1011

A checklist to help your pull request get merged faster:

  • Summarize your changes
  • Data: link to resources that verify support information (such as browser's docs, changelogs, source control, bug trackers, and tests)
  • Data: if you tested something, describe how you tested with details like browser and version
  • Review the results of the linter and fix problems reported (If you need help, please ask in a comment!)
  • Link to related issues or pull requests, if any

@jpmedley
Copy link
Contributor

jpmedley commented Jan 4, 2019

He's right. Here's the commit that removed the runtime flag. It's in 45. The actual implementation itself was also in 45, in case you're curious.

I looked it up because the old tables are a secondary source and should always be viewed with suspicion.

@ddbeck ddbeck added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Jan 4, 2019
@ddbeck
Copy link
Collaborator

ddbeck commented Jan 4, 2019

Just to be clear of your meaning, @jpmedley, you mean that @kenrick95 is right and the original table was wrong?

@jpmedley
Copy link
Contributor

jpmedley commented Jan 4, 2019

Changing it to 45 is the correct action, not because the original table says so, but because the commits I linked to say so.

Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR and welcome to BCD, @kenrick95! Looks good! 🎉

@ddbeck ddbeck merged commit 7b2ac31 into mdn:master Jan 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants