Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add compat data for Client#frameType and Client#postMessage #1059

Merged
merged 3 commits into from
Feb 14, 2018

Conversation

germain-gg
Copy link
Contributor

That should complete #980

api/Client.json Outdated
"version_added": null
},
"opera_android": {
"version_added": null
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both versions of Opera should be 30.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I look up the Client#frameType page on MDN Opera states support has unknown? Not too sure what data source to trust?

Happy to make changes if needed. Just wanna double check

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gsouquet: Yes, @jpmedley is our human reference for Chromia like Opera :-)

api/Client.json Outdated
"mdn_url": "https://developer.mozilla.org/docs/Web/API/Client/frameType",
"support": {
"webview_android": {
"version_added": false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be 43.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Android section on the frameType page specifies not supported. However Chrome for android says version 43.
Do you still want me to go ahead and make the change?
I believe that Chrome for Android has its own entry in the __compat object

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gsouquet: @jpmedley is the ultimate reference for Chrome/Webview Android/Chrome for Android.

@teoli2003 teoli2003 added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Feb 13, 2018
@germain-gg
Copy link
Contributor Author

All comments fixed! Thanks @jpmedley for the feedback

Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
I don't why this was added, but please remove the changes to package-lock.json

@germain-gg
Copy link
Contributor Author

@Elchi3 done, I believe I might have run npm install with a different node version which resulted in a different output for the package-lock.json file.
To prevent this, should we have an engine entry in the package.json https://docs.npmjs.com/files/package.json#engines or maybe add a .nvmrc file?

Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Elchi3 Elchi3 merged commit a7df2f0 into mdn:master Feb 14, 2018
@Elchi3
Copy link
Member

Elchi3 commented Feb 14, 2018

@gsouquet I'm not sure. Maybe it's me who needs to update to a newer node or npm version? I will double check. In any case, should be discussed in a new issue if this is a problem.

dontcallmedom pushed a commit to dontcallmedom/browser-compat-data that referenced this pull request Mar 17, 2018
foolip added a commit to foolip/browser-compat-data that referenced this pull request May 11, 2022
Original source: mdn#1059

No source was given, but it might have been this:
https://storage.googleapis.com/chromium-find-releases-static/f77.html#f777755953e905594276a99cf64fc3848406d5f6

However, that commit was in time for Chrome 36 or 37, well before
Service Workers were first enabled. So match the parent feature.

Part of mdn#7844.
queengooborg pushed a commit that referenced this pull request May 11, 2022
Original source: #1059

No source was given, but it might have been this:
https://storage.googleapis.com/chromium-find-releases-static/f77.html#f777755953e905594276a99cf64fc3848406d5f6

However, that commit was in time for Chrome 36 or 37, well before
Service Workers were first enabled. So match the parent feature.

Part of #7844.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants