Audit Chrome 45 versions #7844

foolip · 2020-12-14T23:39:36Z

The "Find Releases" tool at the bottom of https://omahaproxy.appspot.com/ is often used by BCD contributors to figure out which Chrome release a certain Chromium commit was first included in.

Back in Sep 2015, the Blink and Chromium repositories were merged. That was for Chrome 47. Whether related to that merge or not, I have observed that trying to use the "Find Releases" tool with commits much older than that often incorrectly says that something was in Chrome 45, despite it actually being in an earlier release.

As an example, https://storage.googleapis.com/chromium-find-releases-static/243.html#24375f20cd603d56b8847b329209964c1281ba7a says "initially landed in 45.0.2454.101" but looking up the time of the commit with https://www.chromium.org/developers/calendar gives Chrome 43. I've seen this many times.

I would treat Chrome 45 as worthy of extra scrutiny in review, and moreover think we should go over the list of features in npm run traverse chrome api 45 and make sure the data can be confirmed by http://mdn-bcd-collector.appspot.com/. Where we have no tests, the existing data might well be wrong because of this reason.

@ddbeck @Elchi3 @jpmedley @sideshowbarker @vinyldarkscratch FYI

The text was updated successfully, but these errors were encountered:

foolip · 2021-07-20T17:50:56Z

See #11631 (comment) about CSSGroupingRule, a change that did happen in Chrome 45 but should perhaps be tweaked per https://github.com/mdn/browser-compat-data/blob/main/docs/data-guidelines.md#apis-moved-on-the-prototype-chain

foolip · 2021-10-21T09:40:51Z

@jpmedley FYI about this problem. I see that #4398 (review) is a case of this, where Chrome 45 was set incorrectly. In that case it's actually Chrome 43 so a very minor problem, but the errors can be bigger with other APIs.

The source of this data is this comment: mdn#4398 (review) However, because of a problem with Chromium's "Find Releases" tool, Chrome 45 is often claimed for commits older than that: mdn#7844 Chrome 43 was confirmed by testing 42 and 43 with this test: http://mdn-bcd-collector.appspot.com/tests/api/RTCIceCandidate/toJSON Chrome 43 is also what commit date + branch point dates suggests: https://source.chromium.org/chromium/chromium/src/+/4a6ce1a6ad82c9b9f16bcb136303acadf08422ea https://www.chromium.org/developers/calendar

jpmedley · 2021-10-21T20:18:46Z

Thanks Joe Medley | Technical Writer, Chrome DevRel | ***@***.*** | 816-678-7195 *If an API's not documented it doesn't exist.*

…

On Thu, Oct 21, 2021 at 2:41 AM Philip Jägenstedt ***@***.***> wrote: @jpmedley <https://github.com/jpmedley> FYI about this problem. I see that #4398 (review) <#4398 (review)> is a case of this, where Chrome 45 was set incorrectly. In that case it's actually Chrome 44 so a very minor problem, but the errors can be bigger with other APIs. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#7844 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB6S7CZTBWOEGFGYV7ZCEODUH7N25ANCNFSM4U3PWRGA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

The source of this data is this comment: #4398 (review) However, because of a problem with Chromium's "Find Releases" tool, Chrome 45 is often claimed for commits older than that: #7844 Chrome 43 was confirmed by testing 42 and 43 with this test: http://mdn-bcd-collector.appspot.com/tests/api/RTCIceCandidate/toJSON Chrome 43 is also what commit date + branch point dates suggests: https://source.chromium.org/chromium/chromium/src/+/4a6ce1a6ad82c9b9f16bcb136303acadf08422ea https://www.chromium.org/developers/calendar

This was added to Chromium well before FetchEvent was first enabled: https://chromium.googlesource.com/chromium/src/+/d5cfd088444bebf83231bf4de9916c9fcca8e093 But the chromium-find-releases-static tool shows the wrong version: https://storage.googleapis.com/chromium-find-releases-static/d5c.html#d5cfd088444bebf83231bf4de9916c9fcca8e093 Firefox removal confirmed: https://bugzilla.mozilla.org/show_bug.cgi?id=1264175 Part of mdn#7844.

Confirmed by testing in Chrome 43: https://mdn-bcd-collector.appspot.com/tests/api/MIDIAccess Chrome 45 was set in mdn#3716 based on this: https://storage.googleapis.com/chromium-find-releases-static/545.html#5455496fc3b82a0dc6645f78474f9ab5950a70bb But that's wrong. Part of mdn#7844.

Confirmed by testing in Chrome 37+38: https://mdn-bcd-collector.appspot.com/tests/javascript/builtins/Symbol/unscopables This now matches Array.@@unscopables: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/@@unscopables#browser_compatibility Part of mdn#7844.

foolip · 2022-05-09T13:24:50Z

Burndown list to verify or fixed based on npm run traverse chrome all 45:

api.CSSGroupingRule.* - Audit Chrome 45 versions #7844 (comment)
api.CSSKeyframesRule.appendRule (as insertRule) - confirmed by https://mdn-bcd-collector.appspot.com/tests/api/CSSKeyframesRule
api.Client.postMessage - Update Chromium versions for Client.postMessage #16243
api.Document.pointerlockchange_event (webkit prefix) - Update removal versions of webkitpointerlockchange/error events #16223
api.Document.pointerlockerror_event (webkit prefix) - Update removal versions of webkitpointerlockchange/error events #16223
api.FetchEvent.isReload - Fix versions and status of FetchEvent.isReload #16174
api.FontFace.load - Remove incorrect notes about FontFace's load()/loaded promises #16225
api.FontFace.loaded - Remove incorrect notes about FontFace's load()/loaded promises #16225
api.HTMLElement.contextMenu - Mark HTMLElement.contextMenu as never shipped in Chromium #16244
api.HTMLLinkElement.integrity - confirmed by https://mdn-bcd-collector.appspot.com/tests/api/HTMLLinkElement/integrity
api.HTMLScriptElement.integrity - confirmed by https://mdn-bcd-collector.appspot.com/tests/api/HTMLScriptElement/integrity
api.MIDIAccess.sysexEnabled - Fix Chromium versions for MIDIAccess.sysexEnabled #16175
api.MediaQueryList.EventListener_objects - Update Chromium versions for MediaQueryList #16248
api.MediaQueryList.EventTarget_inheritance - Update Chromium versions for MediaQueryList #16248
api.MediaQueryList.change_event - Update Chromium versions for MediaQueryList #16248
api.MediaStream.active - Update Chromium versions for MediaStream.active and events #16229
api.MediaStream.active_event - Update Chromium versions for MediaStream.active and events #16229
api.MediaStream.clone - Update Chromium versions for MediaStream/MediaStreamTrack's clone() #16245
api.MediaStream.getTracks - Update Chromium versions for MediaStream.getTracks #16246
api.MediaStream.inactive_event - Update Chromium versions for MediaStream.active and events #16229
api.MediaStreamTrack.clone - Update Chromium versions for MediaStream/MediaStreamTrack's clone() #16245
api.Notification.worker_support - Update worker support for Notifications in Chromium #16249
api.PerformanceEntry.toJSON - https://github.com/mdn/browser-compat-data/pull/8279/files#r871032696
api.Range.compareNode - confirmed by https://mdn-bcd-collector.appspot.com/tests/api/Range/compareNode
api.SVGFESpecularLightingElement.kernelUnitLengthX/Y - confirmed by https://mdn-bcd-collector.appspot.com/tests/api/SVGFESpecularLightingElement
api.SVGRenderingIntent - Add Chromium versions for SVGRenderingIntent API #7818
api.ServiceWorkerContainer.getRegistrations - confirmed by https://mdn-bcd-collector.appspot.com/tests/api/ServiceWorkerContainer/getRegistrations
api.ServiceWorkerRegistration.showNotification.options_actions_parameter - Fix Chrome/Edge versions for showNotification's options.actions parameter #16261
api.ServiceWorkerRegistration.showNotification.options_vibrate_parameter - confirmed by date of https://chromium.googlesource.com/chromium/src/+/ed64f71325ef3d3eb55b3dc4b0e6571a9049d237
api.ServiceWorkerRegistration.update - confirmed by https://mdn-bcd-collector.appspot.com/tests/api/ServiceWorkerRegistration/update
api.Text.replaceWholeText - Remove irrelevant feature Text.replaceWholeText #16224
api.UIEvent.layerX - Move layerX/layerY from UIEvent to MouseEvent #16267
api.UIEvent.layerY - Move layerX/layerY from UIEvent to MouseEvent #16267
css.at-rules.keyframes.ignore_important_declarations - Q2'19, Chrome: versions for css.at-rules #4021 (comment)
css.at-rules.media.display-mode - Fix Chromium versions for @media (display-mode: ...) #16276
css.properties.list-style-type.* - Complete list-style-type types #4148 (comment)
html.elements.link.integrity - see api.HTMLLinkElement.integrity
html.elements.script.integrity - see api.HTMLScriptElement.integrity
svg.elements.feComposite.operator.lighter - Update browser versions for <feComposite operator="lighter"> #16278
javascript.builtins.Array.* - confirmed by https://mdn-bcd-collector.appspot.com/tests/javascript/builtins/Array
javascript.builtins.Object.assign - confirmed by https://mdn-bcd-collector.appspot.com/tests/javascript/builtins/Object/assign
javascript.builtins.Symbol.unscopables - Fix Chromium versions for Symbol.unscopables #16176
javascript.builtins.TypedArray.* - confirmed by https://mdn-bcd-collector.appspot.com/tests/javascript/builtins/TypedArray (eyeballed, mistakes possible)
javascript.functions.arrow_functions - confirmed by https://googlechrome.github.io/samples/arrows-es6/index.html

This was added to Chromium well before FetchEvent was first enabled: https://chromium.googlesource.com/chromium/src/+/d5cfd088444bebf83231bf4de9916c9fcca8e093 But the chromium-find-releases-static tool shows the wrong version: https://storage.googleapis.com/chromium-find-releases-static/d5c.html#d5cfd088444bebf83231bf4de9916c9fcca8e093 Firefox removal confirmed: https://bugzilla.mozilla.org/show_bug.cgi?id=1264175 Part of mdn#7844.

Confirmed by testing in Chrome 37+38: https://mdn-bcd-collector.appspot.com/tests/javascript/builtins/Symbol/unscopables This now matches Array.@@unscopables: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/@@unscopables#browser_compatibility Part of #7844.

This was added to Chromium well before FetchEvent was first enabled: https://chromium.googlesource.com/chromium/src/+/d5cfd088444bebf83231bf4de9916c9fcca8e093 But the chromium-find-releases-static tool shows the wrong version: https://storage.googleapis.com/chromium-find-releases-static/d5c.html#d5cfd088444bebf83231bf4de9916c9fcca8e093 Firefox removal confirmed: https://bugzilla.mozilla.org/show_bug.cgi?id=1264175 Part of #7844.

Confirmed by testing in Chrome 43: https://mdn-bcd-collector.appspot.com/tests/api/MIDIAccess Chrome 45 was set in #3716 based on this: https://storage.googleapis.com/chromium-find-releases-static/545.html#5455496fc3b82a0dc6645f78474f9ab5950a70bb But that's wrong. Part of #7844.

Confirmed with these test: https://mdn-bcd-collector.appspot.com/tests/api/Document/webkitpointerlockchange_event https://mdn-bcd-collector.appspot.com/tests/api/Document/webkitpointerlockerror_event Part of mdn#7844.

The source of this is mdn#3560. That linked to the IDL cleanup: https://chromium.googlesource.com/chromium/src/+/4e5bd2dafd23ae978222f7e4a73225a89a567f55 That made no actual, observable changes, as noted: > There are no changes to the generated code, other than order. Part of mdn#7844.

This is based on testing Chrome 41 and 42 with a staging version of mdn-bcd-collector with these updated tests: foolip/mdn-bcd-collector#1991 Part of mdn#7844.

Original source: mdn#1059 No source was given, but it might have been this: https://storage.googleapis.com/chromium-find-releases-static/f77.html#f777755953e905594276a99cf64fc3848406d5f6 However, that commit was in time for Chrome 36 or 37, well before Service Workers were first enabled. So match the parent feature. Part of mdn#7844.

Original source: mdn#3502 However, this was behind a flag [RuntimeEnabled=ContextMenu] and never shipped. Related bits like html.elements.menuitem and html.global_attributes.contextmenu are already set to false. Part of mdn#7844.

Original source: mdn#3958 However, https://chromium.googlesource.com/chromium/src/+/776e9a66223e95141b0b8bc6c6f9a847cd5fd8c4 was long before Chrome 45. Support was tested using `webkitMediaStream.prototype.clone` and `MediaStreamTrack.prototype.clone` in Chrome 34 and 45. (One interface was prefixed at the time.) Part of mdn#7844.

Original source: mdn#3958 However, https://chromium.googlesource.com/chromium/src/+/776e9a66223e95141b0b8bc6c6f9a847cd5fd8c4 was long before Chrome 45. Support was tested using `webkitMediaStream.prototype.clone` and `MediaStreamTrack.prototype.clone` in Chrome 34 and 35. (One interface was prefixed at the time.) Part of mdn#7844.

Original source: mdn#3958 However, https://chromium.googlesource.com/chromium/src/+/e99d73de1761aec44e23381e565ee48430d9a699 was long before Chrome 45. Support was tested using `webkitMediaStream.prototype.getTracks` in Chrome 37 and 38. Part of mdn#7844.

Original source: mdn#3255 https://chromium.googlesource.com/chromium/src/+/5fc555b830a9b5b1536e242d8754d7e507bcc75a was used as the source, which is the right commit but it wasn't first in Chrome 45 but earlier. At the time, the MediaQueryList interface had [NoInterfaceObject], but because MediaQueryListEvent was implemented/exposed at the same time, we can assume that the versions should match. Chrome 39 was confirmed with this test: https://mdn-bcd-collector.appspot.com/tests/api/MediaQueryListEvent The data for MediaQueryListEvent already matches. Part of mdn#7844.

Original source: mdn#1768 No evidence for the specific versions were given. The mere exposure of Notification in dedicated workers can be confirmed to be Chrome 41 with this test: https://mdn-bcd-collector.appspot.com/tests/api/Notification?exposure=Worker However, Notifications can't be created from dedicated workers in Chromium, it makes more sense to match support in service workers, which is one version later. That then matches notes and other data like api.NotificationEvent and api.ServiceWorkerRegistration.showNotification. Part of mdn#7844.

Original source: mdn#1768 No evidence for the specific versions was given. The mere exposure of Notification in dedicated workers can be confirmed to be Chrome 41 with this test: https://mdn-bcd-collector.appspot.com/tests/api/Notification?exposure=Worker However, Notifications can't be created from dedicated workers in Chromium, it makes more sense to match support in service workers, which is one version later. That then matches notes and other data like api.NotificationEvent and api.ServiceWorkerRegistration.showNotification. Part of mdn#7844.

Original source: #1768 No evidence for the specific versions was given. The mere exposure of Notification in dedicated workers can be confirmed to be Chrome 41 with this test: https://mdn-bcd-collector.appspot.com/tests/api/Notification?exposure=Worker However, Notifications can't be created from dedicated workers in Chromium, it makes more sense to match support in service workers, which is one version later. That then matches notes and other data like api.NotificationEvent and api.ServiceWorkerRegistration.showNotification. Part of #7844.

Original source: #3255 https://chromium.googlesource.com/chromium/src/+/5fc555b830a9b5b1536e242d8754d7e507bcc75a was used as the source, which is the right commit but it wasn't first in Chrome 45 but earlier. At the time, the MediaQueryList interface had [NoInterfaceObject], but because MediaQueryListEvent was implemented/exposed at the same time, we can assume that the versions should match. Chrome 39 was confirmed with this test: https://mdn-bcd-collector.appspot.com/tests/api/MediaQueryListEvent The data for MediaQueryListEvent already matches. Part of #7844.

Original source: #3958 However, https://chromium.googlesource.com/chromium/src/+/e99d73de1761aec44e23381e565ee48430d9a699 was long before Chrome 45. Support was tested using `webkitMediaStream.prototype.getTracks` in Chrome 37 and 38. Part of #7844.

…16245) Original source: #3958 However, https://chromium.googlesource.com/chromium/src/+/776e9a66223e95141b0b8bc6c6f9a847cd5fd8c4 was long before Chrome 45. Support was tested using `webkitMediaStream.prototype.clone` and `MediaStreamTrack.prototype.clone` in Chrome 34 and 35. (One interface was prefixed at the time.) Part of #7844.

Original source: #1059 No source was given, but it might have been this: https://storage.googleapis.com/chromium-find-releases-static/f77.html#f777755953e905594276a99cf64fc3848406d5f6 However, that commit was in time for Chrome 36 or 37, well before Service Workers were first enabled. So match the parent feature. Part of #7844.

Original source: mdn#4369 The source given, which is unfortunately wrong: https://storage.googleapis.com/chromium-find-releases-static/02b.html#02b80e73d179e8b87d007b197766fa5fca1a80ee Chrome 42 was confirmed by testing and commit date: https://software.hixie.ch/utilities/js/live-dom-viewer/?saved=10306 https://chromium.googlesource.com/chromium/src/+/02b80e73d179e8b87d007b197766fa5fca1a80ee https://www.chromium.org/developers/calendar/ Part of mdn#7844.

Original source: #4369 The source given, which is unfortunately wrong: https://storage.googleapis.com/chromium-find-releases-static/02b.html#02b80e73d179e8b87d007b197766fa5fca1a80ee Chrome 42 was confirmed by testing and commit date: https://software.hixie.ch/utilities/js/live-dom-viewer/?saved=10306 https://chromium.googlesource.com/chromium/src/+/02b80e73d179e8b87d007b197766fa5fca1a80ee https://www.chromium.org/developers/calendar/ Part of #7844.

Original source: mdn#9074 This demo was used to test: https://yari-demos.prod.mdn.mozit.cloud/en-US/docs/Web/SVG/Element/feComposite/_sample_.example.html The following support was confirmed with BrowserStack: - Chrome 41 (not in 40) - Edge 79 (not in 18) - Firefox 86 (not in 85) - Safari 10.1 (not in 9.1) The precise Safari version was determined by source: https://trac.webkit.org/changeset/195745/webkit https://trac.webkit.org/browser/webkit/trunk/Source/WebCore/Configurations/Version.xcconfig?rev=195745 WebKit trunk version 602.1.18 maps to Safari 10 (using WebKit 602.1.50). Part of mdn#7844.

queengooborg · 2022-05-13T19:19:58Z

All Chrome 45 data has now been audited!

queengooborg added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Dec 15, 2020

ddbeck removed the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Dec 17, 2020

This was referenced Dec 29, 2020

Add Chromium versions for MediaQueryListEvent API #8433

Merged

Add Chromium versions for CanvasRenderingContext2D API hit regions #8434

Closed

queengooborg added the bulk_update 📦 An update to a mass amount of data, or scripts/linters related to such changes label May 6, 2021

foolip mentioned this issue Jul 20, 2021

Add CSSGroupingRule properties #11631

Merged

foolip mentioned this issue Oct 21, 2021

Fix version for api.RTCIceCandidate.toJSON #12987

Merged

foolip mentioned this issue Nov 29, 2021

Update data for BeforeInstallPrompt event #12856

Merged

foolip mentioned this issue May 9, 2022

Fix versions and status of FetchEvent.isReload #16174

Merged

foolip mentioned this issue May 9, 2022

Fix Chromium versions for MIDIAccess.sysexEnabled #16175

Merged

foolip mentioned this issue May 9, 2022

Fix Chromium versions for Symbol.unscopables #16176

Merged

foolip mentioned this issue May 10, 2022

Update removal versions of webkitpointerlockchange/error events #16223

Merged

foolip mentioned this issue May 10, 2022

Remove incorrect notes about FontFace's load()/loaded promises #16225

Merged

foolip mentioned this issue May 10, 2022

Update Chromium versions for MediaStream.active and events #16229

Merged

foolip mentioned this issue May 11, 2022

Mark HTMLElement.contextMenu as never shipped in Chromium #16244

Merged

foolip mentioned this issue May 11, 2022

Update Chromium versions for MediaStream/MediaStreamTrack's clone() #16245

Merged

foolip mentioned this issue May 11, 2022

Update Chromium versions for MediaStream.getTracks #16246

Merged

This was referenced May 11, 2022

Update Chromium versions for MediaQueryList #16248

Merged

Update worker support for Notifications in Chromium #16249

Merged

This was referenced May 12, 2022

Add Chromium versions for PerformanceEntry API #8279

Merged

Q2'19, Chrome: versions for css.at-rules #4021

Merged

foolip mentioned this issue May 13, 2022

Fix Chromium versions for @media (display-mode: ...) #16276

Merged

This was referenced May 13, 2022

Complete list-style-type types #4148

Closed

Update browser versions for <feComposite operator="lighter"> #16278

Merged

foolip mentioned this issue May 13, 2022

Add feComposite support for operator attribute's lighter value #9074

Merged

queengooborg closed this as completed May 13, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Audit Chrome 45 versions #7844

Audit Chrome 45 versions #7844

foolip commented Dec 14, 2020

foolip commented Jul 20, 2021

foolip commented Oct 21, 2021 •

edited

Loading

jpmedley commented Oct 21, 2021 via email

foolip commented May 9, 2022 •

edited

Loading

queengooborg commented May 13, 2022

Audit Chrome 45 versions #7844

Audit Chrome 45 versions #7844

Comments

foolip commented Dec 14, 2020

foolip commented Jul 20, 2021

foolip commented Oct 21, 2021 • edited Loading

jpmedley commented Oct 21, 2021 via email

foolip commented May 9, 2022 • edited Loading

queengooborg commented May 13, 2022

foolip commented Oct 21, 2021 •

edited

Loading

foolip commented May 9, 2022 •

edited

Loading