[Chrome] Correct MediaQueryList. #3255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddbeck
added
the
data:api 🐇
ddbeck
approved these changes
Jan 4, 2019
foolip
added a commit
to foolip/browser-compat-data
that referenced
this pull request
May 11, 2022
Original source: mdn#3255 https://chromium.googlesource.com/chromium/src/+/5fc555b830a9b5b1536e242d8754d7e507bcc75a was used as the source, which is the right commit but it wasn't first in Chrome 45 but earlier. At the time, the MediaQueryList interface had [NoInterfaceObject], but because MediaQueryListEvent was implemented/exposed at the same time, we can assume that the versions should match. Chrome 39 was confirmed with this test: https://mdn-bcd-collector.appspot.com/tests/api/MediaQueryListEvent The data for MediaQueryListEvent already matches. Part of mdn#7844.
queengooborg
pushed a commit
that referenced
this pull request
May 11, 2022
Original source: #3255 https://chromium.googlesource.com/chromium/src/+/5fc555b830a9b5b1536e242d8754d7e507bcc75a was used as the source, which is the right commit but it wasn't first in Chrome 45 but earlier. At the time, the MediaQueryList interface had [NoInterfaceObject], but because MediaQueryListEvent was implemented/exposed at the same time, we can assume that the versions should match. Chrome 39 was confirmed with this test: https://mdn-bcd-collector.appspot.com/tests/api/MediaQueryListEvent The data for MediaQueryListEvent already matches. Part of #7844.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The items changed to '45' are from this CL. All other changes are things that should have been copied from the interface level.
A checklist to help your pull request get merged faster: