Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move layerX/layerY from UIEvent to MouseEvent #16267

Merged
merged 1 commit into from
May 13, 2022

Conversation

foolip
Copy link
Collaborator

@foolip foolip commented May 12, 2022

These are non-standard properties, but if they are standardized it will
be on MouseEvent, see w3c/uievents#135.

Furthermore, it's only on MouseEvent that these properties ever return
something other than zero.

The apparent removal in Chrome 45 was caused by the move from UIEvent to
MouseEvent in Chromium:
https://bugs.chromium.org/p/chromium/issues/detail?id=503276

Since MouseEvent inherits from UIEvent, we can ignore this prototype
move in BCD, per our guidelines:
https://github.com/mdn/browser-compat-data/blob/main/docs/data-guidelines.md#apis-moved-on-the-prototype-chain

These are non-standard properties, but if they are standardized it will
be on MouseEvent, see w3c/uievents#135.

Furthermore, it's only on MouseEvent that these properties ever return
something other than zero.

The apparent removal in Chrome 45 was caused by the move from UIEvent to
MouseEvent in Chromium:
https://bugs.chromium.org/p/chromium/issues/detail?id=503276

Since MouseEvent inherits from UIEvent, we can ignore this prototype
move in BCD, per our guidelines:
https://github.com/mdn/browser-compat-data/blob/main/docs/data-guidelines.md#apis-moved-on-the-prototype-chain
@foolip foolip requested a review from queengooborg May 12, 2022 17:48
@github-actions github-actions bot added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label May 12, 2022
@foolip foolip mentioned this pull request May 12, 2022
@teoli2003 teoli2003 added the needs content update 📝 This PR needs a corresponding update to mdn/content to update the documentation label May 12, 2022
@teoli2003
Copy link
Contributor

We have these two pages on mdn/content that needs to be adapted/removed:

https://developer.mozilla.org/en-US/docs/Web/API/UIEvent/layerX
https://developer.mozilla.org/en-US/docs/Web/API/UIEvent/layerY

Setting the Needs content update label.

Copy link
Collaborator

@queengooborg queengooborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Will merge once the content is updated as well. 👍

@foolip
Copy link
Collaborator Author

foolip commented May 13, 2022

Content update sent in mdn/content#15993.

@sideshowbarker sideshowbarker merged commit 74598b8 into mdn:main May 13, 2022
@foolip foolip deleted the MouseEvent-layerXY branch May 17, 2022 10:56
@queengooborg queengooborg removed the needs content update 📝 This PR needs a corresponding update to mdn/content to update the documentation label Jul 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants