Add Chromium versions for CanvasRenderingContext2D API hit regions #8434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
data:api 🐇
|
This also needs double checking due to #7844. |
queengooborg
deleted the
api/CanvasRenderingContext2D-hitRegions-chrome
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds real values for Chromium for the hit regions features of the CanvasRenderingContext2D API based upon Chromium commit history. Tracking down the exact commit when this was added, I found it was introduced in Chrome 45, behind a flag. Additionally, I had determined supported
addHitRegionparameters by skimming through the source C++ code itself to find references, along with commit history for thefillRuleoption.