Add Chromium versions for PerformanceEntry API #8279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds real values for Chromium (Chrome, Opera, Samsung Internet, WebView Android) for the `PerformanceEntry` API, based upon results from the [mdn-bcd-collector](https://mdn-bcd-collector.appspot.com) project (v1.1.8). Results are manually confirmed for accuracy. Tests Used: https://mdn-bcd-collector.appspot.com/tests/api/PerformanceEntry
github-actions
bot
added
the
data:api 🐇
foolip
approved these changes
Dec 24, 2020
foolip
reviewed
May 12, 2022
| @@ -284,10 +296,10 @@ | |||
| "mdn_url": "https://developer.mozilla.org/docs/Web/API/PerformanceEntry/toJSON", | |||
| "support": { | |||
| "chrome": { | |||
| "version_added": true | |||
| "version_added": "45" | |||
There was a problem hiding this comment.
This is suspect because of #7844. The collector doesn't use commit mapping at all of course, but I double checked to confirm 45 anyway:
PerformanceEntry.prototype.hasOwnProperty('toJSON')tested in Chrome 44 and 45- https://chromium.googlesource.com/chromium/src/+/64d41ea9eeb27ea0897a190b62e44e2f1d57ed48 is Jul 9th, 2015
- https://www.chromium.org/developers/calendar/ branch point for 45 is Jul 10th, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds real values for Chromium (Chrome, Opera, Samsung Internet, WebView Android) for the
PerformanceEntryAPI, based upon results from the mdn-bcd-collector project (v1.1.8). Results are manually confirmed for accuracy.Tests Used: https://mdn-bcd-collector.appspot.com/tests/api/PerformanceEntry