Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create workflow to label PRs needing rebase #15931

Merged
merged 4 commits into from
May 3, 2022
Merged

Conversation

queengooborg
Copy link
Collaborator

This PR adds a GitHub Actions workflow to automatically (un)label pull requests that have merge conflicts. Fixes #5154.

@github-actions github-actions bot added the infra 🏗️ Infrastructure issues (npm, GitHub Actions, releases) of this project label Apr 20, 2022
.github/workflows/pr-rebase-needed.yml Outdated Show resolved Hide resolved
.github/workflows/pr-rebase-needed.yml Outdated Show resolved Hide resolved
.github/workflows/pr-rebase-needed.yml Outdated Show resolved Hide resolved
.github/workflows/pr-rebase-needed.yml Outdated Show resolved Hide resolved
@Rumyra
Copy link
Collaborator

Rumyra commented Apr 27, 2022

This looks good to me 👍 making @schalkneethling aware of it in case we want something similar on other repos in the future (maybe not rebase, but something)

@schalkneethling
Copy link

This would actually be useful on Yari at the very least. @queengooborg, do you want to open a PR on mdn/workflows to this as a reusable action?

@queengooborg
Copy link
Collaborator Author

I opened mdn/workflows#33 which adds the workflow to our reusable workflows. I'd be happy to rework this PR to use the global workflow if/when it's merged!

@schalkneethling
Copy link

I opened mdn/workflows#33 which adds the workflow to our reusable workflows. I'd be happy to rework this PR to use the global workflow if/when it's merged!

Thank you! Just reviewed your pull request.

@Rumyra
Copy link
Collaborator

Rumyra commented May 3, 2022

From what I can tell this is using the mdn/workflows one now - are we good to go?

@queengooborg
Copy link
Collaborator Author

Yep, we're all good to go!

@schalkneethling
Copy link

@queengooborg are we waiting on @foolip as well to 👍 ? If not, feel free to merge.

@queengooborg
Copy link
Collaborator Author

Only one owner needs to r+ on PRs to merge infra changes like this, so either Philip, Ruth or Florian (I can't approve my own PRs, sadly :P) is needed to approve and then we can merge!

@schalkneethling schalkneethling merged commit 3150ede into main May 3, 2022
@schalkneethling schalkneethling deleted the pr-rebase-bot branch May 3, 2022 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra 🏗️ Infrastructure issues (npm, GitHub Actions, releases) of this project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use compat‑data‑helper to handle automatic application and removal of the rebase needed tag
4 participants