Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add linter for experimental+deprecated statuses #6813

Merged
merged 21 commits into from
May 23, 2022
Merged

Add linter for experimental+deprecated statuses #6813

merged 21 commits into from
May 23, 2022

Conversation

saschanaz
Copy link
Contributor

@saschanaz saschanaz commented Oct 3, 2020 •
edited
Loading

A checklist to help your pull request get merged faster:

@saschanaz saschanaz requested a review from ddbeck as a code owner October 3, 2020 20:48
@github-actions github-actions bot added the linter 🏡 Issues or pull requests regarding the tests / linter of the JSON files. label Oct 3, 2020
@queengooborg queengooborg added not ready ⛔ This is not yet ready to be merged. It's pending a decision, other PR, or a prerequisite action. and removed not ready ⛔ This is not yet ready to be merged. It's pending a decision, other PR, or a prerequisite action. labels Oct 5, 2020
queengooborg
queengooborg requested changes Oct 5, 2020
View reviewed changes
test/linter/test-experimental.js Outdated Show resolved Hide resolved
test/linter/test-experimental.js Outdated Show resolved Hide resolved
@queengooborg queengooborg added the not ready ⛔ This is not yet ready to be merged. It's pending a decision, other PR, or a prerequisite action. label Oct 5, 2020
@queengooborg
Copy link
Collaborator

Marking as "not ready" since we'll need to do some data updates before this linter passes.

@saschanaz
Copy link
Contributor Author

saschanaz commented Oct 5, 2020 •
edited
Loading

webextensions should probably be excluded as it has no spec. (Edit: I excluded experimental+nonstandard cases in this PR, maybe for followup)

@saschanaz saschanaz mentioned this pull request Oct 6, 2020
Closed
@saschanaz saschanaz changed the title Add linter for incorrect experimental statuses Add linter for experimental+deprecated statuses Oct 7, 2020
@github-actions github-actions bot added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Oct 7, 2020
@queengooborg queengooborg mentioned this pull request Nov 13, 2020
Open
@saschanaz
Copy link
Contributor Author

@ddbeck could you remove the rebase needed flag? 👀

@ddbeck ddbeck added not ready ⛔ This is not yet ready to be merged. It's pending a decision, other PR, or a prerequisite action. and removed not ready ⛔ This is not yet ready to be merged. It's pending a decision, other PR, or a prerequisite action. labels Nov 18, 2020
@ddbeck ddbeck removed their request for review December 17, 2020 16:25
Base automatically changed from master to main March 24, 2021 12:54
@github-actions github-actions bot added the scripts 📜 Issues or pull requests regarding the scripts in scripts/. label Apr 20, 2022
@foolip foolip mentioned this pull request Apr 21, 2022
Closed
@saschanaz
Copy link
Contributor Author

I love #15931.

@github-actions
Copy link

This pull request has merge conflicts that must be resolved before we can merge this.

@saschanaz
Copy link
Contributor Author

#15913 made this green 🟩

@foolip foolip requested a review from queengooborg May 16, 2022 13:29
@github-actions
Copy link

This pull request has merge conflicts that must be resolved before we can merge this.

@queengooborg queengooborg removed the not ready ⛔ This is not yet ready to be merged. It's pending a decision, other PR, or a prerequisite action. label May 19, 2022
queengooborg
queengooborg requested changes May 20, 2022
View reviewed changes
test/linter/test-status-contradiction.js Outdated Show resolved Hide resolved
test/linter/test-status-contradiction.js Outdated Show resolved Hide resolved
test/linter/test-status-contradiction.js Outdated Show resolved Hide resolved
queengooborg
queengooborg approved these changes May 23, 2022
View reviewed changes
Copy link
Collaborator

@queengooborg queengooborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@queengooborg queengooborg merged commit 6757eb6 into mdn:main May 23, 2022
@saschanaz saschanaz deleted the lint-experimental branch May 23, 2022 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@queengooborg queengooborg queengooborg approved these changes

Assignees
No one assigned
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API linter 🏡 Issues or pull requests regarding the tests / linter of the JSON files. scripts 📜 Issues or pull requests regarding the scripts in scripts/.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@saschanaz @queengooborg @foolip @ddbeck