Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Demix ended event from GlobalEventHandlers #16609

Merged
merged 6 commits into from
Jul 10, 2022
Merged

Demix ended event from GlobalEventHandlers #16609

merged 6 commits into from
Jul 10, 2022

Conversation

queengooborg
Copy link
Contributor

This PR demixes the ended event from the GlobalEventHandlers mixin.

@github-actions github-actions bot added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Jun 9, 2022
@queengooborg queengooborg mentioned this pull request Jun 9, 2022
Closed
@queengooborg queengooborg added the needs content update This PR needs a corresponding update to mdn/content to update the documentation label Jun 13, 2022
@github-actions
Copy link

This pull request has merge conflicts that must be resolved before it can be merged.

1 similar comment
@github-actions
Copy link

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions
Copy link

This pull request has merge conflicts that must be resolved before it can be merged.

foolip
foolip requested changes Jun 22, 2022
View reviewed changes
Copy link
Contributor

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few different "ended" events, but it looks like we have all the ones we need already, in AudioScheduledSourceNode, HTMLMediaElement and MediaStreamTrack.

Can you revert the additions?

@queengooborg queengooborg mentioned this pull request Jul 8, 2022
Merged
@queengooborg queengooborg merged commit 24cb688 into mdn:main Jul 10, 2022
@queengooborg queengooborg removed the needs content update This PR needs a corresponding update to mdn/content to update the documentation label Jul 10, 2022
@queengooborg queengooborg deleted the api/GlobalEventHandlers/ended branch July 25, 2022 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@foolip foolip foolip approved these changes

Assignees
No one assigned
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@queengooborg @foolip