Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Demix ended event from GlobalEventHandlers #18091

Merged
merged 2 commits into from
Jul 10, 2022
Merged

Demix ended event from GlobalEventHandlers #18091

merged 2 commits into from
Jul 10, 2022

Conversation

queengooborg
Copy link
Collaborator

This PR demixes the onended event from the GlobalEventHandlers mixin. Related BCD PR: mdn/browser-compat-data#16609

@queengooborg queengooborg requested review from a team as code owners July 8, 2022 03:07
@queengooborg queengooborg requested review from sideshowbarker and removed request for a team July 8, 2022 03:07
@github-actions github-actions bot added the Content:WebAPI Web API docs label Jul 8, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jul 8, 2022 •
edited
Loading

Preview URLs

Flaws

Note! 1 document with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/GlobalEventHandlers
Title: GlobalEventHandlers
on GitHub
Flaw count: 42

  • macros:
    • /en-US/docs/Web/API/GlobalEventHandlers/onabort redirects to /en-US/docs/Web/API/HTMLMediaElement/abort_event
    • /en-US/docs/Web/API/GlobalEventHandlers/onpointerlockchange does not exist
    • /en-US/docs/Web/API/GlobalEventHandlers/onpointerlockerror does not exist
    • /en-US/docs/Web/API/GlobalEventHandlers/onprogress does not exist
    • /en-US/docs/Web/API/GlobalEventHandlers/onratechange does not exist
    • and 10 more flaws omitted
  • bad_bcd_links:
    • no explanation!
    • no explanation!
    • no explanation!
    • no explanation!
    • no explanation!
    • and 22 more flaws omitted

External URLs

URL: /en-US/docs/Web/API/GlobalEventHandlers
Title: GlobalEventHandlers
on GitHub

No external URLs

URL: /en-US/docs/Web/API/HTMLMediaElement/ended_event
Title: HTMLMediaElement: ended event
on GitHub

No new external URLs

(this comment was updated 2022-07-10 00:48:51.315900)

teoli2003
teoli2003 suggested changes Jul 8, 2022
View reviewed changes
Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An extra sentence to remove…

files/en-us/web/api/htmlmediaelement/ended_event/index.md Outdated Show resolved Hide resolved
@queengooborg @teoli2003
Update files/en-us/web/api/htmlmediaelement/ended_event/index.md
7f5c1f3 
Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>
@teoli2003 teoli2003 merged commit bf6cbfe into mdn:main Jul 10, 2022
@queengooborg queengooborg deleted the onended branch July 10, 2022 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teoli2003 teoli2003 teoli2003 approved these changes

@sideshowbarker sideshowbarker Awaiting requested review from sideshowbarker sideshowbarker is a code owner automatically assigned from mdn/yari-content-web-api

Assignees
No one assigned
Labels
Content:WebAPI Web API docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@queengooborg @teoli2003