Use strict mode for the linter #2288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ExE-Boss
force-pushed
the
linter/use-strict
branch
3 times, most recently
from
c5c3045
to
35fe4de
Compare
Also fixes the issue where an error in a single file would cause all subsequent files to be printed at the end.
Elchi3
added
the
linter 🏡
Elchi3
approved these changes
Jun 20, 2018
There was a problem hiding this comment.
Great clean-up work, @ExE-Boss!
I like your use of Map here a lot.
The changes of var to const or let look correct to me, too. Using more destructuring takes a little bit more for me to get used to, but it looks alright as well. r+
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes the issue where an error in a single file would cause all subsequent files to be printed at the end.Edit: turns out it doesn’t, but #2459 might finally fix it.