Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the linter print better error messages #2338

Merged
merged 5 commits into from
Jan 7, 2019

Conversation

ExE-Boss
Copy link
Contributor

@ExE-Boss ExE-Boss commented Jun 19, 2018

@ExE-Boss ExE-Boss force-pushed the linter/better-errors branch 2 times, most recently from ab3ac7a to 0055257 Compare June 19, 2018 16:57
@Elchi3 Elchi3 added infra 🏗️ Infrastructure issues (npm, GitHub Actions, releases) of this project linter 🏡 Issues or pull requests regarding the tests / linter of the JSON files. rebase-needed 🚧 labels Jun 20, 2018
@ExE-Boss
Copy link
Contributor Author

@Elchi3 I’ve now rebased this and #2155.

@ExE-Boss ExE-Boss force-pushed the linter/better-errors branch 2 times, most recently from a47d0d6 to d5d78b1 Compare July 27, 2018 19:12
@ExE-Boss ExE-Boss mentioned this pull request Sep 28, 2018
21 tasks
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested this and it works great. Good work!
I think it would be good to add ^0.6.0, though. What do you think?

package.json Outdated Show resolved Hide resolved
@ExE-Boss ExE-Boss force-pushed the linter/better-errors branch 5 times, most recently from c7cc775 to 6a0cc3d Compare November 23, 2018 03:39
@ExE-Boss
Copy link
Contributor Author

ExE-Boss commented Nov 23, 2018

review?(@Elchi3): I have now resolved all the merge conflicts with the master branch and updated ajv and better‑ajv‑errors to the latest versions.

Also, updating package‑lock.json was very annoying, as mdn‑confluence keeps failing to install with npm and I use pnpm for my day‑to‑day node package development (which also ignores the mdn‑confluence install issues), but npm ci requires that package.json and package‑lock.json match and pnpm can’t update npm’s package‑lock.json or npm‑shrinkwrap.json (this was also the primary reason why I wanted to avoid having to update yargs to version 12 in #2155).

P.S.: Please merge this before more annoying merge conflicts happen.

@ExE-Boss ExE-Boss force-pushed the linter/better-errors branch 2 times, most recently from ab81502 to 21ff9e0 Compare December 27, 2018 13:13
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question remaining here. Really close to land this now, though. Thanks again for your work! 👍

test/lint.js Outdated Show resolved Hide resolved
test/test-schema.js Show resolved Hide resolved
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! \o/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra 🏗️ Infrastructure issues (npm, GitHub Actions, releases) of this project linter 🏡 Issues or pull requests regarding the tests / linter of the JSON files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants