-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the linter print better error messages #2338
Conversation
ab3ac7a
to
0055257
Compare
0055257
to
395ee06
Compare
395ee06
to
e5fcd93
Compare
a47d0d6
to
d5d78b1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested this and it works great. Good work!
I think it would be good to add ^0.6.0, though. What do you think?
c7cc775
to
6a0cc3d
Compare
review?(@Elchi3): I have now resolved all the merge conflicts with the Also, updating P.S.: Please merge this before more annoying merge conflicts happen. |
ab81502
to
21ff9e0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question remaining here. Really close to land this now, though. Thanks again for your work! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool! \o/
Depends on #2288
Fixes #2330
Fixes #2143
Example result with a failed build