-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chrome 16 / Safari 6 supported border-image-width
CSS property
#25285
Chrome 16 / Safari 6 supported border-image-width
CSS property
#25285
Conversation
This PR updates and corrects version values for Chrome and Safari for the `border-image-width` CSS property. The data comes from the [mdn-bcd-collector](https://mdn-bcd-collector.gooborg.com) project (v10.12.7). _Check out the [collector's guide on how to review this PR](https://github.com/openwebdocs/mdn-bcd-collector#reviewing-bcd-changes)._ Tests Used: https://mdn-bcd-collector.gooborg.com/tests/css/properties/border-image-width
@@ -50,7 +50,7 @@ | |||
], | |||
"support": { | |||
"chrome": { | |||
"version_added": "≤83" | |||
"version_added": "18" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure it is not supported with version 15 (like the property itself?)
"version_added": "18" | |
"version_added": "15" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I'm certain -- I used the collector and tested each version of Chrome to track down the exact version number!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The following evaluates to false
in Chrome 15, and to true
in Chrome 18:
'border-image-width' in document.createElement('div').style
This indicates to me that border-image-width
was only supported from Chrome 18.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And the collector test fails in Chrome 16, because div.style['border-image-width']
is "auto auto auto auto"
when setting it to "auto"
. I guess this could be worth a note about Chrome expanding the short-hand in Chrome 16/17, but it looks like Chrome 16 actually supports this value.
PS: Have you considered capturing some context (here: the actual value, in other cases: the error that calling e.g. a method throws) in the collector test results?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per https://github.com/mdn/browser-compat-data/pull/25285/files#r1870199312, we should:
- Set the Chrome version to 16, also on the parent.
- Possibly add a note about Chrome expanding the short-hand before Chrome 18.
border-image-width
CSS property and auto
value
border-image-width
CSS property and auto
valueborder-image-width
CSS property
This PR updates and corrects version values for Chrome and Safari for the
border-image-width
CSS property. The data comes from the mdn-bcd-collector project (v10.12.7).Check out the collector's guide on how to review this PR.
Tests Used: https://mdn-bcd-collector.gooborg.com/tests/css/properties/border-image-width