Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chrome 16 / Safari 6 supported border-image-width CSS property #25285

Merged
merged 2 commits into from
Dec 10, 2024
Merged

Chrome 16 / Safari 6 supported border-image-width CSS property #25285

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d17c47
Update Chrome/Safari data for border-image-width CSS property
queengooborg Dec 1, 2024
749ca59
Tweak version number
queengooborg Dec 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions css/properties/border-image-width.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
],
"support": {
"chrome": {
"version_added": "≤83"
"version_added": "18"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure it is not supported with version 15 (like the property itself?)

Suggested change
"version_added": "18"
"version_added": "15"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I'm certain -- I used the collector and tested each version of Chrome to track down the exact version number!

Copy link
Contributor

@caugner caugner Dec 4, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The following evaluates to false in Chrome 15, and to true in Chrome 18:

'border-image-width' in document.createElement('div').style

This indicates to me that border-image-width was only supported from Chrome 18.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See also:
image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chrome 16 starts supporting the property, Chrome 18 the auto value:

image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And the collector test fails in Chrome 16, because div.style['border-image-width'] is "auto auto auto auto" when setting it to "auto". I guess this could be worth a note about Chrome expanding the short-hand in Chrome 16/17, but it looks like Chrome 16 actually supports this value.

PS: Have you considered capturing some context (here: the actual value, in other cases: the error that calling e.g. a method throws) in the collector test results?

},
"chrome_android": "mirror",
"edge": {
Expand All @@ -67,7 +67,7 @@
"opera": "mirror",
"opera_android": "mirror",
"safari": {
"version_added": "≤13.1"
"version_added": "6"
},
"safari_ios": "mirror",
"samsunginternet_android": "mirror",
Expand Down