-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjusting SAB support for Chrome on Android #9600
Conversation
Reflecting SAB support Chrome on Android starting M89
"version_removed": "63", | ||
"notes": "Chrome disabled SharedArrayBuffer on January 5, 2018 to help reduce the efficacy of <a href='https://www.chromium.org/Home/chromium-security/ssca'>speculative side-channel attacks</a>. This is intended as a temporary measure until other mitigations are in place." | ||
"version_added": "89", | ||
"notes": "SharedArrayBuffer are available on Android gated behind COOP/COEP" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ddbeck or @Elchi3 for notes review. I'm thinking we should link these terms to https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Cross-Origin-Opener-Policy and https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Cross-Origin-Embedder-Policy, or is there another article that explains what to do for COOP+COEP-guarded features?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Linking to https://web.dev/coop-coep/ might be better?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is also https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/SharedArrayBuffer/Planned_changes but it is a bit outdated given these are not "planned changes" anymore.
More pointers to docs that got written for this story are in mdn/sprints#2219
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Elchi3 is it OK to link to web.dev in the meantime?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. I filed mdn/content#3489 for MDN.
Hi @lutzvahl, thanks for starting on this PR. Also I noticed it's your first here—welcome! I was wondering, do you plan to revisit it based on the feedback provided? |
Adjusting chrome_android versions to reflect M60-63 and new SAB gating behind COOP/COEP starting M91
Sorry for the delay, adjusted the changes based on the provided feedback. What about the link, discussed in: mdn/content#3489? Can we link to web.dev? |
Yeah, I think the decision at #9600 (comment) was that it would be OK to link to that. Would you like to update the notes? It would also be nice to comment on mdn/content#3489 that the notes need updating, when the content is updated. Finally, the CI is failing because of trailing white space on certain lines. Running Thank you! |
Fixing white spaces Added link to web.dev to the SAB gating notes
I now see another issue in the logs for line 27 which was not adjusted at all by my last commit. Can someone please take a look and fix? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've pushed the npm run fix
changes to the branch, which should correct the whitespace CI failure. I've left some copy editing suggestions in line comments. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! 🎉
(Applied the changes myself, to get this into today's release.)
Adjusting the page to reflect the SAB support in Chrome on Android starting M89