Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjusting SAB support for Chrome on Android #9600

Merged
merged 7 commits into from
Apr 22, 2021
Merged

Adjusting SAB support for Chrome on Android #9600

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
81f3d09
SAB support Chrome on Android
lutzvahl Mar 25, 2021
30114bc
Adjusted the chrome_android versions as requested
lutzvahl Apr 12, 2021
e5b94d4
Adjusting chrome_android versions
lutzvahl Apr 12, 2021
9cecb8a
Update SharedArrayBuffer.json
lutzvahl Apr 16, 2021
3fcccd1
Fix whitespace issues
ddbeck Apr 21, 2021
73079fc
Apply suggestions from code review
ddbeck Apr 22, 2021
2a41ac1
Fix unescaped quotes
ddbeck Apr 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 6 additions & 12 deletions javascript/builtins/SharedArrayBuffer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,8 @@
}
],
"chrome_android": {
"version_added": "60",
"version_removed": "63",
"notes": "Chrome disabled SharedArrayBuffer on January 5, 2018 to help reduce the efficacy of <a href='https://www.chromium.org/Home/chromium-security/ssca'>speculative side-channel attacks</a>. This is intended as a temporary measure until other mitigations are in place."
"version_added": "89",
lutzvahl marked this conversation as resolved.
Show resolved Hide resolved
"notes": "SharedArrayBuffer are available on Android gated behind COOP/COEP"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ddbeck or @Elchi3 for notes review. I'm thinking we should link these terms to https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Cross-Origin-Opener-Policy and https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Cross-Origin-Embedder-Policy, or is there another article that explains what to do for COOP+COEP-guarded features?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linking to https://web.dev/coop-coep/ might be better?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is also https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/SharedArrayBuffer/Planned_changes but it is a bit outdated given these are not "planned changes" anymore.

More pointers to docs that got written for this story are in mdn/sprints#2219

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Elchi3 is it OK to link to web.dev in the meantime?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. I filed mdn/content#3489 for MDN.

},
"edge": [
{
Expand Down Expand Up @@ -146,9 +145,8 @@
}
],
"chrome_android": {
"version_added": "60",
"version_removed": "63",
"notes": "Chrome disabled SharedArrayBuffer on January 5, 2018 to help reduce the efficacy of <a href='https://www.chromium.org/Home/chromium-security/ssca'>speculative side-channel attacks</a>. This is intended as a temporary measure until other mitigations are in place."
"version_added": "89",
"notes": "SharedArrayBuffer are available on Android gated behind COOP/COEP"
},
"edge": [
{
Expand Down Expand Up @@ -275,9 +273,7 @@
}
],
"chrome_android": {
"version_added": "60",
"version_removed": "63",
"notes": "Chrome disabled SharedArrayBuffer on January 5, 2018 to help reduce the efficacy of <a href='https://www.chromium.org/Home/chromium-security/ssca'>speculative side-channel attacks</a>. This is intended as a temporary measure until other mitigations are in place."
"version_added": "89"
},
"edge": [
{
Expand Down Expand Up @@ -404,9 +400,7 @@
}
],
"chrome_android": {
"version_added": "60",
"version_removed": "63",
"notes": "Chrome disabled SharedArrayBuffer on January 5, 2018 to help reduce the efficacy of <a href='https://www.chromium.org/Home/chromium-security/ssca'>speculative side-channel attacks</a>. This is intended as a temporary measure until other mitigations are in place."
"version_added": "89"
},
"edge": [
{
Expand Down