Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Behind pref] change togglePopover to return a boolean #27417

Closed
josepharhar opened this issue Jun 19, 2023 · 9 comments
Closed

[Behind pref] change togglePopover to return a boolean #27417

josepharhar opened this issue Jun 19, 2023 · 9 comments
Assignees
Labels
Content:WebAPI Web API docs fx release archive A closed issue relating to firefox release notes for developers.

Comments

@josepharhar
Copy link

MDN URL

https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/togglePopover

What specific section or headline is this issue about?

No response

What information was incorrect, unhelpful, or incomplete?

The togglePopover article is not up to date with this spec change: whatwg/html#9393

What did you expect to see?

We are modifying togglePopover to return a boolean. It will return true if the popover is open after calling togglePopover, otherwise false.

Do you have any supporting links, references, or citations?

No response

Do you have anything more you want to share?

No response

@josepharhar josepharhar added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Jun 19, 2023
@github-actions github-actions bot added the Content:WebAPI Web API docs label Jun 19, 2023
@hamishwillee
Copy link
Collaborator

MDN documents things once there is a browser implementation (specifically Safari, Chromium, Firefox). The linked item indicates WebKit has done this but not showing up in Internet search. Is this in a Safari release yet?

@josepharhar
Copy link
Author

I don't think safari has released this behavior yet.
It should be released in chrome 116 in august

@hamishwillee
Copy link
Collaborator

Thanks. Feel free to ping here if you see any of them appearing in the wild. If nothing else, our process will catch a firefox release.

@Josh-Cena Josh-Cena added waiting for implementations Waiting for feature to be implemented in browsers and removed needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. labels Jun 22, 2023
@Rumyra Rumyra added Firefox 115 and removed waiting for implementations Waiting for feature to be implemented in browsers labels Jul 11, 2023
@Rumyra Rumyra moved this from Backlog to Todo in MDN Web Docs Content Team Jul 11, 2023
@Rumyra
Copy link
Collaborator

Rumyra commented Jul 11, 2023

FF bugzilla https://bugzilla.mozilla.org/show_bug.cgi?id=1833570 - we can make this change. I've added to our FF project

@hamishwillee
Copy link
Collaborator

hamishwillee commented Jul 14, 2023

@Rumyra Following some investigation https://bugzilla.mozilla.org/show_bug.cgi?id=1833570 is in the same area (popovers), but is unrelated to this specific spec change. FF has definitely not implemented this, and nor has Chrome (even in 116, at least on dev).

I will finish up some tidy up work for #27942 and move this back into backlog on project tracking.

The issue I THINK we need to keep an eye on for FF is https://bugzilla.mozilla.org/show_bug.cgi?id=1842845 (I added dev-doc-needed)

@hamishwillee hamishwillee moved this from In Progress to Backlog in MDN Web Docs Content Team Jul 17, 2023
@hamishwillee hamishwillee moved this from Backlog to Todo in MDN Web Docs Content Team Jul 20, 2023
@Rumyra
Copy link
Collaborator

Rumyra commented Jul 31, 2023

I just came to ref that above bug @hamishwillee - seems its in 117 👍

@hamishwillee
Copy link
Collaborator

Yes, which is why I labeled as 117 :-)

@hamishwillee
Copy link
Collaborator

hamishwillee commented Jul 31, 2023

Status:

@hamishwillee hamishwillee changed the title change togglePopover to return a boolean [Behind pref] change togglePopover to return a boolean Jul 31, 2023
@hamishwillee hamishwillee moved this from In Progress to In Review in MDN Web Docs Content Team Aug 1, 2023
@hamishwillee hamishwillee moved this from In Review to Done in MDN Web Docs Content Team Aug 1, 2023
@hamishwillee hamishwillee moved this from Done to In Review in MDN Web Docs Content Team Aug 1, 2023
@Rumyra
Copy link
Collaborator

Rumyra commented Aug 8, 2023

lgtm - thanks @hamishwillee @josepharhar

@Rumyra Rumyra closed this as completed Aug 8, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in MDN Web Docs Content Team Aug 8, 2023
@bsmth bsmth added fx release archive A closed issue relating to firefox release notes for developers. and removed Firefox 117 labels Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebAPI Web API docs fx release archive A closed issue relating to firefox release notes for developers.
Projects
Archived in project
Development

No branches or pull requests

5 participants