Remove WebGLSidebar #22782
Merged
Remove WebGLSidebar #22782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wbamberg
requested review from
sideshowbarker and
bsmth
and removed request for
a team
|
Thanks Will, taking a look 👀 |
bsmth
reviewed
Dec 7, 2022
| 0, 1, 0, 0, | ||
| 0, 0, 1, 0, | ||
| 0, 0, 0, 1 | ||
| ]; |
There was a problem hiding this comment.
Pity to lose the visual aspect of the matrices here, maybe we can revisit this topic in future with one example (in plain or something) that preserves this formatting to illustrate how to visualize this.
There was a problem hiding this comment.
Yes, I agree it's a shame. We could of course use js-nolint in cases like this. I'm on the (code) fence about that practice though.
bsmth
approved these changes
Dec 7, 2022
This was referenced Dec 7, 2022
wbamberg
added a commit
to wbamberg/content
that referenced
this pull request
Dec 8, 2022
* upstream/main: (286 commits) Correct Epsilon property description (mdn#22804) Fix typo in subtle crypto digest (mdn#22802) Alt tag added - reference issue mdn#21616 (mdn#22255) WeakSet: Improve recursive validation example (mdn#22787) New page: validityState.valueMissing (mdn#22691) Edit: <dialog> element (mdn#22786) Update Paint Timing pages (mdn#22771) chore(deps): bump @mdn/yari from 1.27.16 to 1.27.20 (mdn#22791) chore(deps): bump technote-space/get-diff-action from 6.1.1 to 6.1.2 (mdn#22790) Remove WebGLSidebar (mdn#22782) fix indefinite articles usage (mdn#22789) Removed part of sentence that refers to code that appears to have been removed (mdn#22788) Split (Async)?(Generator)?Function class and ctor pages (mdn#22778) Fix interfaces links (mdn#22779) Change "hypertext link" to "hypertext links" (mdn#22780) add hyphenate-limit-chars CSS property (mdn#22747) 22225: Add links to accessibility guides section (mdn#22240) ci(markdownlint): use GitHub API to get changed files (mdn#22773) Document font-palette & @font-palette-values with its descriptors (mdn#22519) fix typo in createImageBitmap api (mdn#22774) ...
hamishwillee
pushed a commit
to hamishwillee/content
that referenced
this pull request
Dec 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the custom sidebar
WebGLSidebarin en-US. When it's merged I will deprecate this sidebar.The PR takes advantage of the "Tutorial" section that authors can now add to
DefaultAPISidebar, as of mdn/yari#7646.We also need to list the tutorial pages in groupdata.
Then we need to replace
WebGLSidebarmacro calls withDefaultAPISidebar.Finally, Prettier noise.