Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit: <dialog> element #22786

Merged
merged 2 commits into from
Dec 7, 2022
Merged

Edit: <dialog> element #22786

merged 2 commits into from
Dec 7, 2022

Conversation

estelle
Copy link
Member

@estelle estelle commented Dec 7, 2022

Dialog is well supported
Using dialog is now more accessible than using alternatives to dialog
need to make it clear how to open and close
add inert to page.
make the form method of closing clearer.
openwebdocs/project#137

@estelle estelle requested a review from a team as a code owner December 7, 2022 07:23
@estelle estelle requested review from schalkneethling and removed request for a team December 7, 2022 07:23
@github-actions github-actions bot added the Content:HTML Hypertext Markup Language docs label Dec 7, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2022

Preview URLs

(comment last updated: 2022-12-07 07:37:47)

@teoli2003 teoli2003 merged commit 88f5c89 into mdn:main Dec 7, 2022
wbamberg added a commit to wbamberg/content that referenced this pull request Dec 8, 2022
* upstream/main: (286 commits)
  Correct Epsilon property description (mdn#22804)
  Fix typo in subtle crypto digest (mdn#22802)
  Alt tag added - reference issue mdn#21616 (mdn#22255)
  WeakSet: Improve recursive validation example (mdn#22787)
  New page: validityState.valueMissing (mdn#22691)
  Edit: <dialog> element (mdn#22786)
  Update Paint Timing pages (mdn#22771)
  chore(deps): bump @mdn/yari from 1.27.16 to 1.27.20 (mdn#22791)
  chore(deps): bump technote-space/get-diff-action from 6.1.1 to 6.1.2 (mdn#22790)
  Remove WebGLSidebar (mdn#22782)
  fix indefinite articles usage (mdn#22789)
  Removed part of sentence that refers to code that appears to have been removed (mdn#22788)
  Split (Async)?(Generator)?Function class and ctor pages (mdn#22778)
  Fix interfaces links (mdn#22779)
  Change "hypertext link" to "hypertext links" (mdn#22780)
  add hyphenate-limit-chars CSS property (mdn#22747)
  22225: Add links to accessibility guides section (mdn#22240)
  ci(markdownlint): use GitHub API to get changed files (mdn#22773)
  Document font-palette & @font-palette-values with its descriptors (mdn#22519)
  fix typo in createImageBitmap api (mdn#22774)
  ...
hamishwillee pushed a commit to hamishwillee/content that referenced this pull request Dec 12, 2022
* Edit: <dialog> element

* Edit: <dialog> element
@estelle estelle deleted the dialog6 branch December 29, 2022 06:37
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Content:HTML Hypertext Markup Language docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants