Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARIA: form role as a landmark #29665

Merged
merged 2 commits into from
Oct 31, 2023
Merged

ARIA: form role as a landmark #29665

merged 2 commits into from
Oct 31, 2023

Conversation

estelle
Copy link
Member

@estelle estelle commented Oct 16, 2023 •
edited
Loading

@estelle estelle requested a review from a team as a code owner October 16, 2023 15:42
@estelle estelle requested review from scottaohara and removed request for a team October 16, 2023 15:42
@github-actions github-actions bot added the Content:Accessibility Accessibility docs label Oct 16, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 16, 2023 •
edited
Loading

Preview URLs

(comment last updated: 2023-10-31 08:22:18)

@estelle estelle mentioned this pull request Oct 16, 2023
Closed
chrisdavidmills
chrisdavidmills approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@estelle ah, this old chestnut again. OK, makes perfect sense in this context; thanks! LGTM

@chrisdavidmills chrisdavidmills merged commit 5e793e1 into main Oct 31, 2023
7 checks passed
@chrisdavidmills chrisdavidmills deleted the estelle-patch-2 branch October 31, 2023 09:02
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chrisdavidmills chrisdavidmills chrisdavidmills approved these changes

@scottaohara scottaohara Awaiting requested review from scottaohara scottaohara is a code owner automatically assigned from mdn/yari-content-accessibility

@dipikabh dipikabh Awaiting requested review from dipikabh

Assignees
No one assigned
Labels
Content:Accessibility Accessibility docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@estelle @chrisdavidmills