Update implicit ARIA roles according to spec changes #29546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements changes from w3c/html-aria#425
Implements change from w3c/html-aria@ba30b83
Implements changes from w3c/html-aria#392
krkk
commented
Oct 8, 2023
| <code><a href="/en-US/docs/Web/Accessibility/ARIA/Roles/form_role">form</a></code> if the form has an | ||
| <a href="https://www.w3.org/TR/accname-1.1/#dfn-accessible-name">accessible name</a>, otherwise | ||
| <a href="https://www.w3.org/TR/html-aria/#dfn-no-corresponding-role">no corresponding role</a> | ||
| <code><a href="/en-US/docs/Web/Accessibility/ARIA/Roles/form_role">form</a></code> |
There was a problem hiding this comment.
While this condition got removed in the spec, there's now a note saying quite the same thing in the cell next to it.
Removed it anyway for the sake of completeness, but I'd like someone to verify if it's alright or what should be done instead.
estelle
approved these changes
Oct 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
spec changes
Motivation
I was in a small argument about
<blockquote>. got surprised that it doesn't have any implicit ARIA role. checked the spec, the spec says it actually assigns a role for it. duh confused, think i should do something about it. in the meantime i'll check if anything else needs updating... ohooohhhh motivation,,,
To stay up to date with the spec! :3
Additional details
Related issues and pull requests
Didn't touch
<summary>element as there's already #28602 openedbeing sleepy and not knowing what to write in pr templates doesn't end well. sry