Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial: update implict role mappings #425

Merged
merged 5 commits into from
Jul 22, 2022
Merged

Editorial: update implict role mappings #425

merged 5 commits into from
Jul 22, 2022

Conversation

scottaohara
Copy link
Member

@scottaohara scottaohara commented Jul 8, 2022 •
edited by pr-preview bot
Loading

the following are meant to be treated as generic elements:

  • a no href
  • area no href
  • b
  • bdi
  • bdo
  • pre
  • q
  • u
  • small
  • data
  • samp
  • span
  • i

related to #406

related HTML AAM issue: w3c/html-aam#373

Preview | Diff

@scottaohara
Editorial: update implict role mappings
280e02c 
the following are meant to be treated as generic elements:
- a  no href
- area no href
- b
- bdi
- bdo
- pre
- q
- u
- small

related to #406
@scottaohara scottaohara added the editorial non-normative updates label Jul 8, 2022
@scottaohara scottaohara added this to the ARIA in HTML 1.1 milestone Jul 8, 2022
@scottaohara
update 3 more elements
137adae 
data, samp and span all map to generic as well
@scottaohara
Copy link
Member Author

note, not all these updates have landed in HTML AAM yet. but, as per last week's ARIA deep dive call, it was agreed that all these elements do make sense to map to generic.

@mtrootyy
Copy link

mtrootyy commented Jul 9, 2022

Isn't i element meant to be treated as generic elements?

@scottaohara
Copy link
Member Author

scottaohara commented Jul 9, 2022 •
edited
Loading

Yup. Thought I had done it with this PR, but clearly not

stevefaulkner
stevefaulkner reviewed Jul 13, 2022
View reviewed changes
Copy link
Collaborator

@stevefaulkner stevefaulkner left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wondering about <pre> as it is a block level element that could benefit from being named/described?

@scottaohara
Copy link
Member Author

@stevefaulkner pre was discussed during the ARIA working group deep dive on elements that still needed roles, and it was determined to not be necessary, as even in the case where it might be beneficial to name it, it could always be contained within another element that does allow for naming.

@stevefaulkner stevefaulkner self-requested a review July 13, 2022 14:43
@scottaohara scottaohara merged commit 02f5e96 into gh-pages Jul 22, 2022
@scottaohara scottaohara deleted the partial-406 branch July 22, 2022 21:19
estelle pushed a commit to mdn/content that referenced this pull request Oct 14, 2023
@krkk
Update implicit ARIA roles according to spec changes (#29546)
e31cb59 
* Set implicit role mappings to `generic`

Implements changes from w3c/html-aria#425

* Set address' element implicit role to `group`

Implements change from w3c/html-aria@ba30b83

* Assign ARIA 1.2 roles to elements

Implements changes from w3c/html-aria#392

* Make `<section>` with inaccessible name's implicit role to be `generic`

See w3c/html-aria#475

* Set implicit ARIA mapping for <s> element to `deletion`

See w3c/html-aria#469

* Set `form` as the only implicit ARIA role for the form element

See w3c/html-aria#402
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickhlauke patrickhlauke Awaiting requested review from patrickhlauke

@stevefaulkner stevefaulkner Awaiting requested review from stevefaulkner

Assignees
No one assigned
Labels
editorial non-normative updates
Projects
None yet
Milestone
ARIA in HTML 1.1
Development

Successfully merging this pull request may close these issues.
3 participants
@scottaohara @mtrootyy @stevefaulkner