Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(games) Remove broken links, refer to WebXR instead of WebVR API #30696

Merged
merged 2 commits into from
Dec 1, 2023

Conversation

bsmth
Copy link
Member

@bsmth bsmth commented Dec 1, 2023

Removing a few dead links.

Broken URLs:

Notes:
The WebVR article needs a little refresh to make sure prose is all pointing to WebXR instead. Leaving this for a follow-up. Maybe @zfox23 would like to have a look 👀

@bsmth bsmth requested a review from a team as a code owner December 1, 2023 11:01
@bsmth bsmth requested review from zfox23 and removed request for a team December 1, 2023 11:01
@github-actions github-actions bot added the Content:Games Games docs label Dec 1, 2023
Copy link
Contributor

github-actions bot commented Dec 1, 2023

Preview URLs

External URLs (7)

URL: /en-US/docs/Games/Techniques/3D_on_the_web/Building_up_a_basic_demo_with_Three.js
Title: Building up a basic demo with Three.js


URL: /en-US/docs/Games/Techniques/3D_on_the_web/WebVR
Title: WebVR — Virtual Reality for the Web

(comment last updated: 2023-12-01 15:41:08)

@bsmth bsmth changed the title chore(games) Remove broken links, refer to WebXR instead of WebVR API fix(games) Remove broken links, refer to WebXR instead of WebVR API Dec 1, 2023
Copy link
Contributor

@zfox23 zfox23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty! I'll also take a look at the page that need refreshed to WebXR as you said.

files/en-us/games/techniques/3d_on_the_web/webvr/index.md Outdated Show resolved Hide resolved
files/en-us/games/techniques/3d_on_the_web/webvr/index.md Outdated Show resolved Hide resolved
Co-authored-by: Zach Fox <3409031+zfox23@users.noreply.github.com>
@bsmth bsmth requested a review from zfox23 December 1, 2023 15:39
@bsmth
Copy link
Member Author

bsmth commented Dec 1, 2023

ty! I'll also take a look at the page that need refreshed to WebXR as you said.

Great, thank you!

@zfox23 zfox23 merged commit 18f8a64 into mdn:main Dec 1, 2023
7 checks passed
@bsmth bsmth deleted the 404s-games branch December 1, 2023 15:46
@Wasem9926
Copy link

estelle pushed a commit to estelle/content that referenced this pull request Dec 5, 2023
…dn#30696)

* chore(games) Remove broken links, refer to WebXR instead of WebVR API

* Apply suggestions from code review

Co-authored-by: Zach Fox <3409031+zfox23@users.noreply.github.com>

---------

Co-authored-by: Zach Fox <3409031+zfox23@users.noreply.github.com>
@bsmth bsmth added broken link external The external doc we want to link to exists, but the link href is incorrect. goal: up-to-date (Experimental label) Issues about outdated content. labels Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
broken link external The external doc we want to link to exists, but the link href is incorrect. Content:Games Games docs goal: up-to-date (Experimental label) Issues about outdated content.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants