Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(macros/GamesSidebar): update WebVR -> WebXR link #10111

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

zfox23
Copy link
Contributor

@zfox23 zfox23 commented Dec 1, 2023

Summary

The associated Content PR updates some documentation to refer to WebXR rather than WebVR. This updates a sidebar link to match the new URL.

Motivation

  • Updates a sidebar link.

Additional details

This work came out of a comment on @bsmth's mdn/content#30696.

Related issues and pull requests

Must be merged after mdn/content#30721

@zfox23 zfox23 requested a review from a team as a code owner December 1, 2023 19:06
@github-actions github-actions bot added the macros tracking issues related to kumascript macros label Dec 1, 2023
@caugner caugner changed the title Update WebVR -> WebXR sidebar link chore(macros/GamesSidebar): update WebVR -> WebXR link Dec 4, 2023
Copy link
Contributor

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The newly referenced page does not seem to exist: https://developer.mozilla.org/en-US/docs/Games/Techniques/3D_on_the_web/WebXR

(Also note that WebVR_guide is a key of the localStringMap, and WebXR_guide isn't.)

@caugner caugner marked this pull request as draft December 4, 2023 09:49
@zfox23
Copy link
Contributor Author

zfox23 commented Dec 4, 2023

Right! I mentioned in the description that this PR must be merged after this content PR:
mdn/content#30721

I'll un-draft this after that's merged.

Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving a +1 as the downstream is approved, thank you! 👍🏻

@zfox23 zfox23 marked this pull request as ready for review December 4, 2023 17:53
@zfox23 zfox23 merged commit 77c96dd into mdn:main Dec 4, 2023
9 checks passed
@caugner
Copy link
Contributor

caugner commented Dec 4, 2023

@zfox23 Unfortunately, the menu item no longer shows up:

image

Note that you reference the WebXR_guide key, which doesn't exist in that text map.

(Also note that WebVR_guide is a key of the localStringMap, and WebXR_guide isn't.)

@zfox23
Copy link
Contributor Author

zfox23 commented Dec 4, 2023

@zfox23 Unfortunately, the menu item no longer shows up:
image

Note that you reference the WebXR_guide key, which doesn't exist in that text map.

(Also note that WebVR_guide is a key of the localStringMap, and WebXR_guide isn't.)

My apologies; I didn't understand your earlier comment but now I do. Will fix.

zfox23 added a commit to zfox23/yari that referenced this pull request Dec 4, 2023
zfox23 added a commit to zfox23/yari that referenced this pull request Dec 4, 2023
caugner pushed a commit that referenced this pull request Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
macros tracking issues related to kumascript macros sidebar content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants