Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(macros/GamesSidebar): update WebVR -> WebXR in string map #10126

Merged
merged 1 commit into from
Dec 4, 2023
Merged

fix(macros/GamesSidebar): update WebVR -> WebXR in string map #10126

merged 1 commit into from
Dec 4, 2023

Conversation

zfox23
Copy link
Contributor

@zfox23 zfox23 commented Dec 4, 2023

The menu item no longer shows up:

Oops. See #10111 (comment).

@zfox23 zfox23 requested a review from a team as a code owner December 4, 2023 18:53
@github-actions github-actions bot added the macros tracking issues related to kumascript macros label Dec 4, 2023
@caugner caugner changed the title Follow-up to fix a WebXR sidebar bug I introduced in #10111 fix(macros/GamesSidebar): update WebXR in string map Dec 4, 2023
@caugner caugner changed the title fix(macros/GamesSidebar): update WebXR in string map fix(macros/GamesSidebar): update WebVR -> WebXR in string map Dec 4, 2023
@caugner caugner merged commit 0670f6a into mdn:main Dec 4, 2023
10 checks passed
@github-actions github-actions bot mentioned this pull request Dec 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caugner caugner caugner approved these changes

Assignees
No one assigned
Labels
macros tracking issues related to kumascript macros
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zfox23 @caugner