Fix information for fullscreenchange event #4603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing wrong statement stating that the that "fullscreenchange" event is sent to the Document object when entire document is entered/exited fullscreen mode. But in real, this event never gets sent directly to document, instead when any Element in the document raises fullscreenchange event, it gets bubbled up to the Document object.
chrisdavidmills
approved these changes
Apr 30, 2021
chrisdavidmills
requested review from
chrisdavidmills
and removed request for
jpmedley
Preview URLsFlawsURL:
External URLsURL:
(this comment was updated 2021-04-30 07:29:43.668471) |
wbamberg
pushed a commit
to wbamberg/content
that referenced
this pull request
Apr 30, 2021
* upstream/main: Fix some typos: (mdn#4620) Fix information for fullscreenchange event (mdn#4603) FF89 large ArrayBuffers (mdn#4470) fix: HTML Validation issues (mdn#4612) Make warnings consistent in the JS docs (mdn#4609) fixed typo (mdn#4617) chore(deps): bump @mdn/yari from 0.4.412 to 0.4.413 (mdn#4616) chore(deps): bump technote-space/get-diff-action from v4.0.6 to v4.1.1 (mdn#4615)
|
Thank you so much @chrisdavidmills |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing wrong statement stating that the that "fullscreenchange" event is sent to the Document object when entire document is entered/exited fullscreen mode. But in real, this event never gets sent directly to document, instead when any Element in the document raises fullscreenchange event, it gets bubbled up to the Document object.
https://developer.mozilla.org/en-US/docs/Web/API/Fullscreen_API
#4590
Read above github issue for tested prove