Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed typo #4617

Merged
merged 1 commit into from
Apr 30, 2021
Merged

fixed typo #4617

merged 1 commit into from
Apr 30, 2021

Conversation

AlvinMrema
Copy link
Contributor

The 

 at line 74 did have a class of "brush: html" for styling the html code snippet





What was wrong/why is this fix needed? (quick summary only)






MDN URL of main page changed






Issue number (if there is an associated issue)






Anything else that could help us review it

@AlvinMrema
fixed typo
e97891f 
The <pre> at line 74 did have a class of "brush: html" for styling the html code snippet
@AlvinMrema AlvinMrema requested review from a team and chrisdavidmills and removed request for a team April 30, 2021 06:04
@github-actions
Copy link
Contributor

Preview URLs

Flaws

URL: /en-US/docs/Learn/JavaScript/Client-side_web_APIs/Video_and_audio_APIs
Title: Video and Audio APIs
on GitHub
Flaw count: 1

  • broken_links:
    • Link points to the page it's already on

External URLs

URL: /en-US/docs/Learn/JavaScript/Client-side_web_APIs/Video_and_audio_APIs
Title: Video and Audio APIs
on GitHub

chrisdavidmills
chrisdavidmills approved these changes Apr 30, 2021
View reviewed changes
Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; thanks @AlvinMrema !

@chrisdavidmills chrisdavidmills merged commit 542b3b9 into mdn:main Apr 30, 2021
@AlvinMrema
Copy link
Contributor Author

Welcome @chrisdavidmills

wbamberg pushed a commit to wbamberg/content that referenced this pull request Apr 30, 2021
Merge remote-tracking branch 'upstream/main' into fix-dd-js
e2db47a 
* upstream/main:
  Fix some typos: (mdn#4620)
  Fix information for fullscreenchange event (mdn#4603)
  FF89 large ArrayBuffers (mdn#4470)
  fix: HTML Validation issues (mdn#4612)
  Make warnings consistent in the JS docs (mdn#4609)
  fixed typo (mdn#4617)
  chore(deps): bump @mdn/yari from 0.4.412 to 0.4.413 (mdn#4616)
  chore(deps): bump technote-space/get-diff-action from v4.0.6 to v4.1.1 (mdn#4615)
@AlvinMrema AlvinMrema deleted the patch-4 branch May 20, 2021 09:38
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chrisdavidmills chrisdavidmills chrisdavidmills approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlvinMrema @chrisdavidmills