Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT] add ko translated guildline #878
[FEAT] add ko translated guildline #878
Changes from 8 commits
55debbf
e18eef3
9a19859
98dc0ed
93ee8ca
4003f2c
9087c5b
59564ef
e231628
2cefe2e
87bd21a
9b83a52
9f8859b
9a4d992
2e2b373
3d4ef73
0c2cd54
4d49295
62f8023
65faa5a
bc983f6
1190b6d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
많은 부분에서
참고 자료
로 돼있어서 리뷰했습니다.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
전체 페이지에 대해 검색했을 땐 "같이 보기"가 더 많이 나와요.
>같이 보기<
: 702개 파일 내 702번 등장>See also<
: 377개 파일 내 382번 등장>더 알아보기<
: 93개 파일 내 94번 등장>함께 보기<
: 67개 파일 내 67번 등장>참고\s?자료<
: 6개 파일 내 6번 등장비중은 이렇구요,
<strong>
: 높은 중요도 요소#같이_보기 같은 경우<b>
,<em>
,font-weight
만 있고 외부 링크같은 것이 없어서 "참고 자료"는 덜 어울리지 않을까? 하여요.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
앗 제가 띄어쓰기를 안해서
같이보기
로 검색해서 적게 나왔습니다. 다음에는 의견을 제시할때 저도 정량적 지표와 함께 제시하도록할게요! 이해했습니다. 알려주셔서 감사합니다!저도 동의합니다! 그대로 유지하는게 좋아보입니다. 별도로 향후에
같이 보기(See also)
와 같이 Heading에 영어가 같이 명시돼있는경우에 대해서는 한글만 허용하는게 좋을까요? Heading에 대해서는 혼란을 주는 단어들이 없다고 생각해서 의견을 제시했습니다!There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
네! 헤딩이 뭐시기(Blah) 형식인 것은 1. 모두 오래된 레거시 페이지들이고, 2. 가독성을 너무 해쳐서, 영어 제거하는 쪽에 대찬성합니다
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
네! 좋아요! 답변해주셔서 감사합니다. 좋은 밤 보내세요 :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
순회로 해도 괜찮을까요? 반복("반복 가능한 객체")과 순회("순회 가능한 객체")의 검색 결과 차이가 정말 상당해서요.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Iterator 자체는 반복기/반복자가 좋다고 생각합니다. 역사적으로 볼때 Iterator를 반복기/반복자로 인식하는 사람이 더 많다고 생각합니다.
문제가 Iterate의 경우인데, Iterator를 반복기/반복자라고하고 Iterate는 순회라는 표현을 쓰면 아무래도 혼동이 많을까요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Iterate에 대해서는 의견을 좀 더 모아보면 좋겠네여.
Iterator에 대해서는 아무래도... 그래야 할 것 같아요. -기와 -자 중에서도 -자 쪽이 압도적인 것 같아요. 다만 MSDN은 C# 문서에서 반복기로 사용하고 있긴 하네요.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cos18 @GwangYeol-Im @nKiNk @pje1740 @yechoi42 @yujo11 어떻게 생각하시나요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Iterator는 말씀해주신대로 반복자가 가장 익숙하네요. Iterate는 '순회'로 표기해도 이해하는데 문제없을 것 같습니다. 오히려 반복이 어색한 느낌...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
저도 순회로 하는게 좋은것같습니다. 우선은 순회로 올리겠습니다!