Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(macros): remove deprecated bug/htmlattrdef/xref_cssvisual macros #10003

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

queengooborg
Copy link
Collaborator

This PR removes three deprecated macros from Kumascript: {{bug}}, {{htmlattrdef}} and {{xref_cssvisual}}.

Wait until the following PRs have been merged before merging this one:

@queengooborg queengooborg requested a review from a team as a code owner November 10, 2023 12:09
@github-actions github-actions bot added the macros tracking issues related to kumascript macros label Nov 10, 2023
@caugner caugner marked this pull request as draft November 10, 2023 13:02
@caugner
Copy link
Contributor

caugner commented Nov 10, 2023

Converted to draft as we're waiting for the downstream PRs to be merged.

@yin1999
Copy link
Member

yin1999 commented Dec 12, 2023

We've removed all those three macros, could we go ahead now :)

@queengooborg queengooborg marked this pull request as ready for review December 12, 2023 14:27
@github-actions github-actions bot added the idle label Jan 24, 2024
@caugner caugner changed the title chore(macros): Remove deprecated bug/htmlattrdef/xref_cssvisual macros chore(macros): remove deprecated bug/htmlattrdef/xref_cssvisual macros Mar 27, 2024
Copy link
Contributor

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified via: yarn tool macro-usage-report --deprecated-only

macro yari en-us es fr ja ko pt-br ru zh-cn zh-tw
bug 🗑 - - - - - - - - - -
CSSAnimatedProperties 🗑 - - - 1 - 1 - - - -
DOMAttributeMethods 🗑 - - 6 12 13 1 3 4 12 -
event 🗑 - - - - - 61 77 130 - -
htmlattrdef 🗑 - - - - - - - - - -
no_tag_omission 🗑 - - 27 29 70 59 32 50 60 16
page 🗑 - - - - - - 47 2 - -
unimplemented_inline 🗑 - - - - - - - - - -
xref_cssvisual 🗑 - - - - - - - - - -

@caugner caugner merged commit 9a90d17 into mdn:main Mar 27, 2024
9 checks passed
@queengooborg queengooborg deleted the macros/deprecated-removal branch March 27, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
idle macros tracking issues related to kumascript macros
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants