smartlink to fallback on en-US #3133
Conversation
|
@chrisdavidmills I basically just took your suggestion. @schalkneethling Please review my use of the @fiji-flo Would it be better to go through the |
|
@schalkneethling I know you have a lot on your plate, but would you mind giving this a quick review for any a11y concerns, specifically regarding the use of |
kumascript/src/api/web.js
Outdated
| return ( | ||
| '<a class="page-only-in-english" ' + | ||
| 'title="Page currently only available in English" ' + | ||
| `href="${enUSPage.url}"${flawAttribute}>${content} <small>(en-US)</small></a>` | ||
| ); | ||
| } |
There was a problem hiding this comment.
| return ( | |
| '<a class="page-only-in-english" ' + | |
| 'title="Page currently only available in English" ' + | |
| `href="${enUSPage.url}"${flawAttribute}>${content} <small>(en-US)</small></a>` | |
| ); | |
| } | |
| return ( | |
| '<a class="page-only-in-english" ' + | |
| 'title="Page currently only available in English" ' + | |
| `href="${enUSPage.url}"${flawAttribute}>${content} <span>(en-US)</span></a>` | |
| ); |
Then in client/src/document/index.scss add the following:
.page-only-in-english {
span {
font-size: $small-font-size;
}
}
There was a problem hiding this comment.
Sure. Will do.
But why add more CSS that can be expressed semantically with HTML? I'm not questioning, I'm trying to learn.
There was a problem hiding this comment.
I know, sometimes I want to change my mind about the use of these elements but, we would need CSS anyhow to ensure that the small element uses the $small-font-size. I am kinda undecided on that one.
|
I changed the tooltip slightly too. Not saying the word "Page". Or "Document". Just... |
peterbe
force-pushed
the
3053-smartlink-to-fallback-on-en-us
branch
from
e5e04f5
to
968d9cd
Compare
* smartLink to fallback on en-US Fixes mdn#3053 * finish * feedbacked
Fixes #3053
Before (http://localhost:3000/ca/docs/Web/JavaScript/Reference/Global_Objects/Array/reverse):
After:
Before (http://localhost:3000/de/docs/Web/CSS/Reference):
After:
