Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

smartlink to fallback on en-US #3133

Merged
merged 6 commits into from
Mar 9, 2021
Merged

smartlink to fallback on en-US #3133

Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c605f86
smartLink to fallback on en-US
peterbe Mar 3, 2021
6308a7c
Merge branch 'main' into 3053-smartlink-to-fallback-on-en-us
peterbe Mar 4, 2021
74f2b2f
Merge branch 'main' into 3053-smartlink-to-fallback-on-en-us
peterbe Mar 4, 2021
f59dc53
finish
peterbe Mar 4, 2021
dc96985
Merge branch 'main' into 3053-smartlink-to-fallback-on-en-us
peterbe Mar 9, 2021
968d9cd
feedbacked
peterbe Mar 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions kumascript/src/api/web.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,27 @@ module.exports = {
page.url + hrefhash
}"${titleAttribute}${flawAttribute}>${content}</a>`;
}
if (!href.toLowerCase().startsWith("/en-us/")) {
// Before flagging this as a broken-link flaw, see if it's possible to
// change it to the en-US URL instead.
const hrefSplit = href.split("/");
hrefSplit[1] = "en-US";
const enUSPage = this.info.getPageByURL(hrefSplit.join("/"));
if (enUSPage.url) {
// But it's still a flaw. Record it so that translators can write a
// translated document to "fill the hole".
flaw = this.env.recordNonFatalError(
"broken-link",
`${hrefpath} does not exist but fallbacked on ${enUSPage.url}`
peterbe marked this conversation as resolved.
Show resolved Hide resolved
);
flawAttribute = ` data-flaw-src="${util.htmlEscape(flaw.macroSource)}"`;
return (
'<a class="page-only-in-english" ' +
'title="Page currently only available in English" ' +
`href="${enUSPage.url}"${flawAttribute}>${content} <small>(en-US)</small></a>`
);
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return (
'<a class="page-only-in-english" ' +
'title="Page currently only available in English" ' +
`href="${enUSPage.url}"${flawAttribute}>${content} <small>(en-US)</small></a>`
);
}
return (
'<a class="page-only-in-english" ' +
'title="Page currently only available in English" ' +
`href="${enUSPage.url}"${flawAttribute}>${content} <span>(en-US)</span></a>`
);

Then in client/src/document/index.scss add the following:

.page-only-in-english {
  span {
    font-size: $small-font-size;
  }
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. Will do.
But why add more CSS that can be expressed semantically with HTML? I'm not questioning, I'm trying to learn.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know, sometimes I want to change my mind about the use of these elements but, we would need CSS anyhow to ensure that the small element uses the $small-font-size. I am kinda undecided on that one.

}
flaw = this.env.recordNonFatalError(
"broken-link",
`${hrefpath} does not exist`
Expand Down