-
Notifications
You must be signed in to change notification settings - Fork 502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EmbedLiveSample macro does not support translated slugs #4436
Comments
shapkarin
pushed a commit
to shapkarin/yari
that referenced
this issue
Aug 9, 2021
This was referenced Aug 9, 2021
Please see also #3973 which (we hope) will make live samples work more easily with translated content. |
Merged
shapkarin
pushed a commit
to shapkarin/yari
that referenced
this issue
Aug 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
it looks like
EmbedLiveSample
does not works well with slugs in other thanen
language. I guess it's the general problem withEmbedLiveSample
. I got that at issue mdn/translated-content#1985, found the same issues at other languages and there is a lot of the same can be found at PRs. And I that it's the problem withmacro EmbedLiveSample
because saw a lot of other pages with the same problems and also tried that:Steps to reproduce:
EmbedLiveSample
call{{EmbedLiveSample('A_table_of_contents', 500, 300)}}
to the value that title'sid
hasТаблица_контента
like:
But I got the error
As I can see macro EmbedLiveSample or live-sample.js does not works with translated ids and slugs.
The text was updated successfully, but these errors were encountered: