Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EmbedLiveSample macro regression #4883

Closed
escattone opened this issue Nov 5, 2021 · 1 comment · Fixed by #4940
Closed

EmbedLiveSample macro regression #4883

escattone opened this issue Nov 5, 2021 · 1 comment · Fixed by #4940
Assignees
@escattone
Labels
🚉 platform keeping the platform healthy

Comments

@escattone
Copy link
Contributor

Reference

#3973
mdn/content#3548
https://github.com/mdn/content/discussions/5803

Problem

The pull request #3973 introduced a nice fallback algorithm if the heading ID passed into an EmbedLiveSample macro couldn't be found. The fallback algorithm was important because it made live samples less fragile, especially for translated documents.

For some unknown reason, that fallback algorithm is no longer working.

cc @wbamberg
@escattone escattone added the 🚉 platform keeping the platform healthy label Nov 5, 2021
@escattone escattone self-assigned this Nov 5, 2021
@escattone escattone mentioned this issue Nov 11, 2021
Merged
@escattone
Copy link
Contributor Author

This regression was caused by #4535.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@escattone escattone

Labels
🚉 platform keeping the platform healthy
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix regression of embedlivesample fallback algorithm
1 participant
@escattone