Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EmbedLiveSample when there are subheadings #4535

Merged
merged 1 commit into from
Aug 22, 2021

Conversation

mathewhodson
Copy link
Contributor

This fixes a regression introduced by commit 49f5317.

Fixes: mdn/content#8020
Fixes: mdn/content#8124

@mathewhodson mathewhodson changed the title Fix EmbedLiveSample for pages using <div> elements Fix EmbedLiveSample when there are subheadings Aug 21, 2021
This fixes a regression introduced by commit 49f5317.
@mathewhodson
Copy link
Contributor Author

I fixed the lint errors.

Copy link
Contributor

@escattone escattone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch @mathewhodson, thanks so much! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with "perspective": live sample iframe blocked Issue with "<input type="range">": Broken Yari-Demos
2 participants