fix regression of embedlivesample fallback algorithm #4940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
escattone
commented
Nov 11, 2021
| // We're here because we can't find the sectionID, so instead we're going | ||
| // to find the live-sample iframe by its id (iframeID, NOT sectionID), and | ||
| // then collect the closest blocks of code for the live sample. | ||
| const result = collectClosestCode(findSectionStart(this.$, iframeID)); |
There was a problem hiding this comment.
This corrects the bug introduced by #4535.
|
@wbamberg I realize that it's probably unfair to ask you to review the details of this, so removing you as a reviewer, but commenting here just as an FYI. |
fiji-flo
pushed a commit
that referenced
this pull request
Dec 15, 2021
* fix regression of embedlivesample fallback algorithm * clone to avoid altering the cheerio DOM
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4883
Testing
I modified
files/en-us/web/css/_colon_active/index.mdlocally. I removed the argument to both of itsEmbedLiveSamplemacro calls (so they both became simplyEmbedLiveSample()), and then reloaded http://localhost:5000/en-US/docs/web/css/:active.