fix(macros/EmbedLiveSample): move sandbox attr behind ending tag #11292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caugner
changed the title
caugner
approved these changes
Jun 12, 2024
|
@OnkarRuikar Can you update the test expectations in PS: Please fill out the pull request description. Thanks! |
|
Done. Could you make a release right away so that tomorrow I can test the iframe permissions on the live website? Many samples could be broken due to the lack of these permissions... |
caugner
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
sandbox="allow-same-origin allow-scriptsis not getting rendered in the build/preview output.Solution
It is because there is a typo in the EmbedLiveSample macro code. The
%>is misplaced.Screenshots
It is not a visual change.
How did you test this change?
In local before and after change. A after the change the rendered live sample iframe started having
sandbox="allow-same-origin allow-script"permission string.