Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(macros/EmbedLiveSample): move sandbox attr behind ending tag #11292

Merged
merged 2 commits into from
Jun 12, 2024
Merged

fix(macros/EmbedLiveSample): move sandbox attr behind ending tag #11292

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bdc176b
fix(macros): typo in EmbedLiveSample.ejs
OnkarRuikar Jun 12, 2024
d7fcb53
update unit tests
OnkarRuikar Jun 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions kumascript/macros/EmbedLiveSample.ejs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,5 @@ if (height) { %> height="<%= height %>"<% }
%> src="<%- url %>"<%
if (allowedFeatures) { %> allow="<%= allowedFeatures %>"<% }
if ($token) { %> data-token="<%= JSON.stringify($token) %>"<% }
sandbox="allow-scripts allow-same-origin"
%>></iframe></div><%
%> sandbox="allow-same-origin allow-scripts"></iframe></div><%
if (hasScreenshot) { %></td></tr></tbody></table><% } %>
36 changes: 24 additions & 12 deletions kumascript/tests/macros/EmbedLiveSample.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@ describeMacro("EmbedLiveSample", function () {
'<div class="code-example"><div class="example-header"></div><iframe class="sample-code-frame"' +
' title="Quotations sample"' +
' id="frame_quotations"' +
' src="https://live.mdnplay.dev/en-US/docs/Web/HTML/Element/figure/runner.html?id=quotations">' +
' src="https://live.mdnplay.dev/en-US/docs/Web/HTML/Element/figure/runner.html?id=quotations"' +
' sandbox="allow-same-origin allow-scripts">' +
"</iframe></div>"
);
});
Expand All @@ -28,7 +29,8 @@ describeMacro("EmbedLiveSample", function () {
'<div class="code-example"><div class="example-header"></div><iframe class="sample-code-frame"' +
' title="SVG &amp;lt;switch&amp;gt; example sample"' +
' id="frame_svg_ltswitchgt_example"' +
' src="https://live.mdnplay.dev/en-US/docs/Web/SVG/Element/switch/runner.html?id=svg_ltswitchgt_example">' +
' src="https://live.mdnplay.dev/en-US/docs/Web/SVG/Element/switch/runner.html?id=svg_ltswitchgt_example"' +
' sandbox="allow-same-origin allow-scripts">' +
"</iframe></div>"
);
});
Expand All @@ -39,7 +41,8 @@ describeMacro("EmbedLiveSample", function () {
'<div class="code-example"><div class="example-header"></div><iframe class="sample-code-frame"' +
' title="SVG %3Cswitch%3E example sample"' +
' id="frame_svg_switch_example"' +
' src="https://live.mdnplay.dev/en-US/docs/Web/SVG/Element/switch/runner.html?id=svg_switch_example">' +
' src="https://live.mdnplay.dev/en-US/docs/Web/SVG/Element/switch/runner.html?id=svg_switch_example"' +
' sandbox="allow-same-origin allow-scripts">' +
"</iframe></div>"
);
});
Expand All @@ -51,7 +54,8 @@ describeMacro("EmbedLiveSample", function () {
'<div class="code-example"><div class="example-header"></div><iframe class="sample-code-frame"' +
' title="Dégradés linéaires simples sample"' +
' id="frame_dégradés_linéaires_simples"' +
' src="https://live.mdnplay.dev/fr/docs/Web/CSS/Utilisation_de_d%C3%A9grad%C3%A9s_CSS/runner.html?id=d%C3%A9grad%C3%A9s_lin%C3%A9aires_simples">' +
' src="https://live.mdnplay.dev/fr/docs/Web/CSS/Utilisation_de_d%C3%A9grad%C3%A9s_CSS/runner.html?id=d%C3%A9grad%C3%A9s_lin%C3%A9aires_simples"' +
' sandbox="allow-same-origin allow-scripts">' +
"</iframe></div>"
);
});
Expand All @@ -62,7 +66,8 @@ describeMacro("EmbedLiveSample", function () {
'<div class="code-example"><div class="example-header"></div><iframe class="sample-code-frame"' +
' title="&#34;&gt;&lt;script&gt;alert(&#34;XSS&#34;);&lt;/script&gt; sample"' +
' id="frame_scriptalertxssscript"' +
' src="https://live.mdnplay.dev/en-US/docs/Web/HTML/Element/figure/runner.html?id=scriptalertxssscript">' +
' src="https://live.mdnplay.dev/en-US/docs/Web/HTML/Element/figure/runner.html?id=scriptalertxssscript"' +
' sandbox="allow-same-origin allow-scripts">' +
"</iframe></div>"
);
});
Expand All @@ -74,7 +79,8 @@ describeMacro("EmbedLiveSample", function () {
' title="Example sample"' +
' id="frame_example"' +
' width="100%"' +
' src="https://live.mdnplay.dev/en-US/docs/Web/CSS/border-top-width/runner.html?id=example">' +
' src="https://live.mdnplay.dev/en-US/docs/Web/CSS/border-top-width/runner.html?id=example"' +
' sandbox="allow-same-origin allow-scripts">' +
"</iframe></div>"
);
});
Expand All @@ -86,7 +92,8 @@ describeMacro("EmbedLiveSample", function () {
' title="Example sample"' +
' id="frame_example"' +
' width="&#34;&gt;&lt;script&gt;alert(&#34;XSS&#34;);&lt;/script&gt;"' +
' src="https://live.mdnplay.dev/en-US/docs/Web/CSS/border-top-width/runner.html?id=example">' +
' src="https://live.mdnplay.dev/en-US/docs/Web/CSS/border-top-width/runner.html?id=example"' +
' sandbox="allow-same-origin allow-scripts">' +
"</iframe></div>"
);
});
Expand All @@ -98,7 +105,8 @@ describeMacro("EmbedLiveSample", function () {
' title="Images sample"' +
' id="frame_images"' +
' width="100%" height="250"' +
' src="https://live.mdnplay.dev/en-US/docs/Web/HTML/Element/figure/runner.html?id=images">' +
' src="https://live.mdnplay.dev/en-US/docs/Web/HTML/Element/figure/runner.html?id=images"' +
' sandbox="allow-same-origin allow-scripts">' +
"</iframe></div>"
);
});
Expand All @@ -111,7 +119,8 @@ describeMacro("EmbedLiveSample", function () {
' title="增加关键帧 sample"' +
' id="frame_增加关键帧"' +
' width="100%" height="250"' +
' src="https://live.mdnplay.dev/zh-CN/docs/Web/CSS/CSS_Animations/Using_CSS_animations/runner.html?id=%E5%A2%9E%E5%8A%A0%E5%85%B3%E9%94%AE%E5%B8%A7">' +
' src="https://live.mdnplay.dev/zh-CN/docs/Web/CSS/CSS_Animations/Using_CSS_animations/runner.html?id=%E5%A2%9E%E5%8A%A0%E5%85%B3%E9%94%AE%E5%B8%A7"' +
' sandbox="allow-same-origin allow-scripts">' +
"</iframe></div>"
);
});
Expand All @@ -127,7 +136,8 @@ describeMacro("EmbedLiveSample", function () {
' title="%E4%B8%80%E4%B8%AA%E6%A8%A1%E6%9D%BF%E9%AA%A8%E6%9E%B6 sample"' +
' id="frame_一个模板骨架"' +
' width="160" height="160"' +
' src="https://live.mdnplay.dev/zh-CN/docs/Web/API/Canvas_API/Tutorial/Basic_usage/runner.html?id=%E4%B8%80%E4%B8%AA%E6%A8%A1%E6%9D%BF%E9%AA%A8%E6%9E%B6">' +
' src="https://live.mdnplay.dev/zh-CN/docs/Web/API/Canvas_API/Tutorial/Basic_usage/runner.html?id=%E4%B8%80%E4%B8%AA%E6%A8%A1%E6%9D%BF%E9%AA%A8%E6%9E%B6"' +
' sandbox="allow-same-origin allow-scripts">' +
"</iframe></div>"
);
});
Expand All @@ -139,7 +149,8 @@ describeMacro("EmbedLiveSample", function () {
' title="Images sample"' +
' id="frame_images"' +
' width="100%" height="&#34;&gt;&lt;script&gt;alert(&#34;XSS&#34;);&lt;/script&gt;"' +
' src="https://live.mdnplay.dev/en-US/docs/Web/HTML/Element/figure/runner.html?id=images">' +
' src="https://live.mdnplay.dev/en-US/docs/Web/HTML/Element/figure/runner.html?id=images"' +
' sandbox="allow-same-origin allow-scripts">' +
"</iframe></div>"
);
});
Expand All @@ -148,7 +159,8 @@ describeMacro("EmbedLiveSample", function () {
' title="Examples sample"' +
' id="frame_examples"' +
' width="700px" height="700px"' +
' src="https://live.mdnplay.dev/en-US/docs/Web/CSS/flex-wrap/runner.html?id=examples">' +
' src="https://live.mdnplay.dev/en-US/docs/Web/CSS/flex-wrap/runner.html?id=examples"' +
' sandbox="allow-same-origin allow-scripts">' +
"</iframe></div>";
itMacro("Three arguments: ID, width, height (same slug)", function (macro) {
macro.ctx.env.url = "/en-US/docs/Web/CSS/flex-wrap";
Expand Down