-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Issue#115] : add onboarding page when extension is first installed #129
Conversation
Thank you for your PR I've changed some things, trying to make the onboarding page look like the popup. Also I removed the "enable on survol on this page" parameter as it doesn't make any sense here. I'm unsure about the gif idea honestly. I think we should use something else. Also maybe we could add a way to show the changelog using the Git releases feed ? |
Let me know if you have other thoughts around, I can remove the gif. I kind of looks gigantic now. I'll look at the git releases feed |
Great changes, I'm waiting for #131 which adds a new setting and then I'll be able to merge this |
This PR is part of issue#115
Changes made:
bootsrap.js
to have common functionalities which can used by both popup and onboardingThings to further improve (This could be on a separate PR) :
bootstrap.js
Enable Survol on this page
from onboarding page ✅