Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting to disable self-referenced links #131

Merged
merged 4 commits into from
Oct 17, 2020

Conversation

grubdragon
Copy link
Contributor

@grubdragon grubdragon commented Oct 14, 2020

Implemented functionality to disable links which reference the current domain itself.
Tries to tackle issue #120 partially.
TODO: Extend to ship with a blacklist

@mdolr
Copy link
Owner

mdolr commented Oct 15, 2020

I thought about it a bit, maybe we could make things way simpler, by just letting people input websites in a comma separated list rather than hardcoding domains and having a switch for each one, what do you think of this ?

@grubdragon
Copy link
Contributor Author

The only problem with the switches is that it'll call for too many additional switches.
Letting people input a list and add to it domain filtering, and it'll probably work out well. Just thinking about where this input would be located. In the small popup it could be a bit irritating to type.

@mdolr
Copy link
Owner

mdolr commented Oct 17, 2020

We might want to move all of the global settings to a settings page which would make things easier I think

EDIT: I just merged #129 we will now use the onboarding page as a settings page

@mdolr mdolr merged commit 4513d6f into mdolr:master Oct 17, 2020
@grubdragon
Copy link
Contributor Author

Hey! seems like you did the needful. Thanks, I just came into a ton of work, so have been busy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants