-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bb bot pr template #59
Conversation
I think there should particularly be a comment with an ID: |
@wooorm There are contents different with unified. <!--
Read the [contributing guidelines](https://mdxjs.com/community/contribute/).
We are excited about pull requests, but please try to limit the scope, provide a general description of the changes, and remember, it's up to you to convince us to land it.
If this fixes an open issue, link to it in the following way: `Closes GH-123`.
New features and bug fixes should come with tests.
P.S. have you seen our support and contributing docs?
https://mdxjs.com/community/support/
https://mdxjs.com/community/contribute/
--> And this is for the whole |
That seems to be equivalent to https://raw.githubusercontent.com/mdx-js/.github/main/.github/pull-request-template.md? |
ohhh, huh |
Sorry, I thought this was a PR to mdx-js/mdx-analyzer. This should all work. Not sure why it suddenly failed. Maybe GH changed something |
Yup, you’re right. BB was never enabled on this org. So we’ve never seen it respond yet. Here bb infers that the template is wrong! https://github.com/mdx-js/mdx-analyzer/actions/runs/7150409022/job/19473648743?pr=361#step:2:8 |
I don't understand what's the meaning, GH is just working as expected, we are just missing these sections in |
thank you! |
I think the bb bot should throw instead of just warning, how do you think? |
Sure but it’s just a bunch of hacky buggy scripts that works well enough for now, I wouldn’t put time in it! |
See mdx-js/mdx-analyzer#361 (comment)