Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bb bot pr template #59

Merged
merged 1 commit into from
Dec 9, 2023
Merged

Fix bb bot pr template #59

merged 1 commit into from
Dec 9, 2023

Conversation

JounQin
Copy link
Member

@JounQin JounQin commented Dec 9, 2023

@wooorm
Copy link
Member

wooorm commented Dec 9, 2023

I think there should particularly be a comment with an ID: <!--do not edit: $name-->.
The sections are not needed. If remco wants to use custom templates, that should work.
@remcohaszing, what is the reason you have custom templates here? What do you want differently? If there’s nothing differently, they could be removed.

@JounQin
Copy link
Member Author

JounQin commented Dec 9, 2023

@wooorm There are contents different with unified.

<!--
Read the [contributing guidelines](https://mdxjs.com/community/contribute/).
We are excited about pull requests, but please try to limit the scope, provide a general description of the changes, and remember, it's up to you to convince us to land it.
If this fixes an open issue, link to it in the following way: `Closes GH-123`.
New features and bug fixes should come with tests.
P.S. have you seen our support and contributing docs?
https://mdxjs.com/community/support/
https://mdxjs.com/community/contribute/
-->

And this is for the whole mdx-js org, not only for mdx-analyzer.

@wooorm
Copy link
Member

wooorm commented Dec 9, 2023

@wooorm
Copy link
Member

wooorm commented Dec 9, 2023

ohhh, huh

@wooorm
Copy link
Member

wooorm commented Dec 9, 2023

Sorry, I thought this was a PR to mdx-js/mdx-analyzer.

This should all work. Not sure why it suddenly failed. Maybe GH changed something

@wooorm
Copy link
Member

wooorm commented Dec 9, 2023

Yup, you’re right. BB was never enabled on this org. So we’ve never seen it respond yet.

Here bb infers that the template is wrong! https://github.com/mdx-js/mdx-analyzer/actions/runs/7150409022/job/19473648743?pr=361#step:2:8

@JounQin
Copy link
Member Author

JounQin commented Dec 9, 2023

This should all work. Not sure why it suddenly failed. Maybe GH changed something

I don't understand what's the meaning, GH is just working as expected, we are just missing these sections in mdx-js/.github/.github/pull-request-template.md? So bb bot complains some required content missing.

@wooorm wooorm changed the title docs: add sections required by bb bot Fix bb bot pr template Dec 9, 2023
@wooorm wooorm merged commit 4364987 into main Dec 9, 2023
@wooorm wooorm deleted the JounQin-patch-1 branch December 9, 2023 11:02
@wooorm wooorm added 🏗 area/tools This affects tooling 💪 phase/solved Post is done labels Dec 9, 2023
@wooorm
Copy link
Member

wooorm commented Dec 9, 2023

thank you!

@JounQin
Copy link
Member Author

JounQin commented Dec 9, 2023

Yup, you’re right. BB was never enabled on this org. So we’ve never seen it respond yet.

Here bb infers that the template is wrong! https://github.com/mdx-js/mdx-analyzer/actions/runs/7150409022/job/19473648743?pr=361#step:2:8

I think the bb bot should throw instead of just warning, how do you think?

@wooorm
Copy link
Member

wooorm commented Dec 9, 2023

Sure but it’s just a bunch of hacky buggy scripts that works well enough for now, I wouldn’t put time in it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏗 area/tools This affects tooling 💪 phase/solved Post is done
Development

Successfully merging this pull request may close these issues.

2 participants