Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add a workaround for test case on Windows #361

Closed
wants to merge 1 commit into from
Closed

Conversation

JounQin
Copy link
Member

@JounQin JounQin commented Dec 9, 2023

@JounQin JounQin added the 🏡 area/internal This affects the hidden internals label Dec 9, 2023
@JounQin JounQin requested a review from remcohaszing December 9, 2023 09:41
Copy link

changeset-bot bot commented Dec 9, 2023

⚠️ No Changeset found

Latest commit: f9cf44e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the 👋 phase/new Post is being triaged automatically label Dec 9, 2023

This comment has been minimized.

@wooorm
Copy link
Member

wooorm commented Dec 9, 2023

@remcohaszing Isn’t that a difference between VS Code URLs (paths) and Node URL object’s href? 🤔

@JounQin
Copy link
Member Author

JounQin commented Dec 9, 2023

@remcohaszing Isn’t that a difference between VS Code URLs (paths) and Node URL object’s href? 🤔

@wooorm Yes, that's why I mentioned

I believe this could be a vscode core issue.

+               path: '/d:/a/mdx-analyzer/mdx-analyzer/fixtures/node16/link-reference.mdx.md',
-               path: 'd:/a/mdx-analyzer/mdx-analyzer/fixtures/node16/link-reference.mdx.md',

@remcohaszing
Copy link
Member

I’m not really sure why this was happening. I though the issue was introduced by in #356, so it was fixed there before merging.

I’m not really sure why VS Code uses vscode-uri, and why it’s subtly different from Node’s URL. It is very annoying though.

@remcohaszing remcohaszing added 🤷 no/invalid This cannot be acted upon 👎 phase/no Post cannot or will not be acted on labels Dec 11, 2023
@github-actions github-actions bot removed the 👋 phase/new Post is being triaged automatically label Dec 11, 2023
Copy link
Contributor

Hi! This was closed. Team: If this was merged, please describe when this is likely to be released. Otherwise, please add one of the no/* labels.

@JounQin JounQin deleted the ci/test_win branch December 11, 2023 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏡 area/internal This affects the hidden internals 🤷 no/invalid This cannot be acted upon 👎 phase/no Post cannot or will not be acted on
Development

Successfully merging this pull request may close these issues.

3 participants