Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Volar 2.0 alpha #356

Merged
merged 16 commits into from
Dec 11, 2023
Merged

Conversation

johnsoncodehk
Copy link
Contributor

No description provided.

Copy link

changeset-bot bot commented Nov 16, 2023

⚠️ No Changeset found

Latest commit: 05f6ac3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the 👋 phase/new Post is being triaged automatically label Nov 16, 2023
Copy link
Contributor

github-actions bot commented Nov 16, 2023

Hi! It seems you removed the template which we require. Here are our templates (pick the one you want to use and click *raw* to see its source):

I won’t send you any further notifications about this, but I’ll keep on updating this comment, and hide it when done!

Thanks,
— bb

@johnsoncodehk johnsoncodehk changed the title Prepare for Volar 1.12 Update to Volar 2.0 Nov 21, 2023
@johnsoncodehk johnsoncodehk changed the title Update to Volar 2.0 Upgrade to Volar 2.0 Dec 5, 2023
@remcohaszing remcohaszing marked this pull request as ready for review December 7, 2023 15:32
@remcohaszing
Copy link
Member

There’s only a failing test on Windows left, and I’m not sure if the test is wrong or if it’s a Volar bug.

image

@johnsoncodehk
Copy link
Contributor Author

johnsoncodehk commented Dec 7, 2023

Tests pass now. I guess this is the breaking caused by vscode-markdown-languageservice 0.4.0-alpha.7 --> 0.4.0-alpha.8, volar-service-markdown uses "vscode-markdown-languageservice": "~0.4.0-alpha.7" in package.json thus hits the new version.

@johnsoncodehk johnsoncodehk marked this pull request as draft December 7, 2023 17:21
@johnsoncodehk johnsoncodehk marked this pull request as ready for review December 7, 2023 17:58
Copy link
Member

@remcohaszing remcohaszing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the API of @volar/test-utils. I like that it’s an API for testing language servers that’s unrelated to Volar. It’s ok for now, but I think a change like that could be done in a separate PR next time..

@remcohaszing remcohaszing changed the title Upgrade to Volar 2.0 Upgrade to Volar 2.0 alpha Dec 11, 2023
@remcohaszing remcohaszing merged commit a738090 into mdx-js:main Dec 11, 2023
5 checks passed
Copy link
Contributor

Hi! This was closed. Team: If this was merged, please describe when this is likely to be released. Otherwise, please add one of the no/* labels.

@remcohaszing remcohaszing added 🦋 type/enhancement This is great to have 📦 area/deps This affects dependencies 🧒 semver/minor This is backwards-compatible change labels Dec 11, 2023
@remcohaszing remcohaszing deleted the volar-1.12 branch March 2, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 area/deps This affects dependencies 👋 phase/new Post is being triaged automatically 🧒 semver/minor This is backwards-compatible change 🦋 type/enhancement This is great to have
Development

Successfully merging this pull request may close these issues.

2 participants