Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CRA guide #1422

Merged
merged 2 commits into from
Dec 29, 2020
Merged

Update CRA guide #1422

merged 2 commits into from
Dec 29, 2020

Commits on Dec 28, 2020

  1. Update CRA guide 

    Create React App is the most looked at resource by users here on GitHub.
But it’s suggesting an old, unmaintained, and buggy way to use MDX.

This instead updates the guide to use our maintained projects, without
having to eject from CRA.

As CRA itself is an ever-changing “init” tool, which can support MDX by
following a couple steps, I don’t think it’s wise to have an example in
the project: we want folks to do `npx create-react-app ...`, not clone
our custom example.

Not having CRA checked in also makes for a faster `yarn install`.

Perhaps developing our own [CRA
template](https://create-react-app.dev/docs/custom-templates) might be
nice for the future, but for now I’ve kept it at an up to date and
working guide.

Related to GH-1015.
Related to GH-1388.

Closes GH-365.
Closes GH-589.
    @wooorm
    wooorm committed Dec 28, 2020
    Configuration menu
    Copy the full SHA
    ab8b787 View commit details
    Browse the repository at this point in the history

  2. Add note on typescript

    @wooorm
    wooorm committed Dec 28, 2020
    Configuration menu
    Copy the full SHA
    2e33237 View commit details
    Browse the repository at this point in the history