This repository has been archived by the owner on Aug 30, 2021. It is now read-only.
fix(dependency): Mongoose 4.4.7 bug #1264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an issue with Mongoose `4.4.7` that causes the database connection.db property to be undefined. This issue is causing our builds to fail. Sets the Mongoose version to `~4.4.3 <4.4.7` for now until we investigate further. This should solve the issue of our failing builds, when the `dropdb` Grunt/Gulp task is ran with the E2E tests.
|
Merging this since it's a small change, and we need to have our builds passing. It's disruptive to all the contributors that the builds aren't passing. @meanjs/contributors |
mleanos
added a commit
that referenced
this pull request
Mar 13, 2016
fix(dependency): Mongoose 4.4.7 bug
|
@mleanos |
mleanos
added a commit
to mleanos/mean
that referenced
this pull request
Mar 18, 2016
Upgrades the Mongoose version to 4.4.8. The need to limit Mongoose version to be less than 4.4.7 is no longer necessary due to a bug fix released with 4.4.8. Resolves the need for meanjs#1264
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue with Mongoose
4.4.7that causes the database connection.db property to be undefined. This issue is causing our builds to fail.Sets the Mongoose version to
~4.4.3 <4.4.7for now until we investigate further. This should solve the issue of our failing builds, when thedropdbGrunt/Gulp task is ran with the E2E tests.For more context:
this line https://github.com/meanjs/mean/blob/master/gruntfile.js#L277 was throwing an exception during our builds, since the
dropdbtask is run with the E2E tests. This seemed to cause the Protractor tasks to time-out. However, there was no indication of this exception being thrown from ourdropdbtask when running withgrunt testor in the Travis builds. I had to explicitly rungrunt test:e2eto see this exception that led me to this fix.