Changes Node Version In Bluemix Pipeline #1265
Conversation
|
Ryan, could you update the commit message header to follow our contribution guidelines? Other than that, this LGTM. |
|
I thought I did...by header do u mean issue title? |
|
I mean the Git commit message header. Right now it's set to "Fix for issue #1138". It should be something similar to what you have in the PR's description. "fix(bluemix): Changes Node Version In Bluemix Pipeline" |
|
I just merged in a fix for a bug that was causing our builds to fail. Can you rebase with upstream? Then the build should pass. I apologize for the inconvenience. |
ryanjbaxter
force-pushed
the
change-pipeline-node-version
branch
from
28da6a1 to
c3d8da9
Compare
|
Hopefully that does it, if not I will take a look at some point tomorrow |
|
The other builds are passing, so I'm sure this one will too. The commit message header looks good now. Thanks. |
| @@ -47,7 +47,7 @@ | |||
| "method-override": "~2.3.5", | |||
| "gulp-wiredep": "~0.0.0", | |||
| "mocha": "~2.4.5", | |||
| "mongoose": "~4.4.3", | |||
| "mongoose": "~4.4.3 <4.4.7", | |||
There was a problem hiding this comment.
why are we limiting the mongoose version number?
There was a problem hiding this comment.
This shouldn't be in this PR. This diff was already merged into master. See #1264. It fixed the issue with our builds failing.
There was a problem hiding this comment.
Ok, got it.
It's ok if it's here then, not a problem.
|
@ryanjbaxter thanks for the PR! |
Changes Node Version In Bluemix Pipeline
fix(bluemix): Changes Node Version In Bluemix Pipeline
Fixes the requirement that MEANJS requires Node.js 0.12 in order to build.
Fixes #1138