Pass args and kwargs to Hessian of objective function #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brocksam
reviewed
Jan 10, 2023
cyipopt/scipy_interface.py
Outdated
Comment on lines
121
to
123
| raise NotImplementedError( | ||
| 'jac has to be bool or a function (got {!r})'.format(type(jac)) | ||
| ) |
There was a problem hiding this comment.
As CyIpopt is now Python>=3.7 can we please make the f-strings instead of using .format()?
brocksam
reviewed
Jan 10, 2023
cyipopt/scipy_interface.py
Outdated
Comment on lines
151
to
153
| raise NotImplementedError( | ||
| 'jac of constraints has to be bool or a function (got {!r})'.format(type(con_jac)) | ||
| ) |
brocksam
reviewed
Jan 10, 2023
cyipopt/scipy_interface.py
Outdated
| @@ -270,6 +274,7 @@ def get_constraint_dimensions(constraints, x0): | |||
|
|
|||
|
|
|||
| def get_constraint_bounds(constraints, x0, INF=1e19): | |||
| TYPE_EQ, TYPE_INEQ = 'eq', 'ineq' | |||
There was a problem hiding this comment.
While this use of tuple unpacking is clever, I personally don't think it's the clearest to read. Can we please split to two assignments over two lines.
brocksam
reviewed
Jan 10, 2023
cyipopt/scipy_interface.py
Outdated
Comment on lines
293
to
296
| msg = "Invalid constraint type: {!r}. Valid types are {}." | ||
| raise ValueError( | ||
| msg.format(con['type'], (TYPE_EQ, TYPE_INEQ)) | ||
| ) |
brocksam
reviewed
Jan 10, 2023
There was a problem hiding this comment.
Great addition, thank you. Especially appreciate the addition of tests for this. To try and keep the code as tidy as possible, please can we try to adhere to PEP8 formatting, particularly separation of top level function and class definitions by two blank lines.
|
Currently blocked by #177. |
|
Can you merge in master here so the tests run in CI? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
argsandkwargsare passed to the Hessian of the objective function. This should fix Objective function not passed extra arguments when Hessian is provided #175.argsandkwargsare passed to the objective, Jacobian and Hessian.raise ImportError()without amsgand hopefully clarified some error messages.