-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
args and kwargs now work fully for minimize_ipopt #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
moorepants
commented
Apr 6, 2023
•
edited
Loading
edited
Actually this does fail for passing args/kwargs into the hessian:
|
moorepants
changed the title
Added a test for args and kwargs in minimize_ipopt.
args and kwargs now work fully for minimize_ipopt
Apr 6, 2023
- Passed in args and kwargs to all IpoptProblemWrapper. - Added a unit test with args and kwargs for all funcs.
moorepants
force-pushed
the
test-args-kwargs
branch
from
April 6, 2023 08:12
0ceb893
to
a55e0bb
Compare
This doesn't break anything, so I'm going to merge. |
This was referenced Apr 6, 2023
This was referenced Apr 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.