Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: include hvc1 codec to load h.265 videos #965

Merged
merged 1 commit into from
Dec 14, 2024

Conversation

ologbonowiwi
Copy link
Contributor

@ologbonowiwi ologbonowiwi commented Dec 14, 2024

/claim #666

Copy link

vercel bot commented Dec 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
screenpipe ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 14, 2024 2:08am

@@ -120,7 +120,7 @@ export const VideoComponent = memo(function VideoComponent({
</div>
) : (
<video controls className="w-full rounded-md">
<source src={mediaSrc} type="video/mp4" />
<source src={mediaSrc} type="video/mp4; codecs=hvc1" />
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried a bunch of different things. video-js, flv-h265.js, but after a few hours of research and trying and error, I learned webkit (the browser thing Mac uses) has native support to h.265 through hvc1 codec.

@louis030195
Copy link
Collaborator

/approve

Copy link

algora-pbc bot commented Dec 14, 2024

@louis030195: The claim has been successfully added to reward-all. You can visit your dashboard to complete the payment.

@louis030195 louis030195 merged commit 294eb22 into mediar-ai:main Dec 14, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants